Page MenuHomePhabricator

Add regular expressions to and DWARF Call Frame Information tests in case the architecture specific target is not compiled into LLVM.
ClosedPublic

Authored by clayborg on Oct 6 2020, 6:56 PM.

Details

Diff Detail

Event Timeline

clayborg created this revision.Oct 6 2020, 6:56 PM
clayborg requested review of this revision.Oct 6 2020, 6:56 PM
labath added a comment.Oct 7 2020, 4:41 AM

This basically removes the testing for the original patch, since all of these tests would now pass even if the feature is completely reverted. Fortunately, I think the fix for that is easy. We don't need to add the regex to tests that already presuppose that the relevant llvm target is available. By the looks of things, that's everything except test/DebugInfo/dwarfdump-debug-frame-simple.test.

llvm/test/DebugInfo/RISCV/eh-frame.s
29 ↗(On Diff #296576)

This test already requires the RISCV target -- see lit.local.cfg.

llvm/test/MC/ELF/cfi-restore-extended.s
9 ↗(On Diff #296576)

This test already requires the X86 target -- see lit.local.cfg. (Also, the llvm-mc cmd would not work without that target.)

llvm/test/MC/Mips/eh-frame.s
69 ↗(On Diff #296576)

This test requires the mips target -- regex unnecessary.

llvm/test/MC/X86/i386-darwin-frame-register.ll
14 ↗(On Diff #296576)

This test requires the x86 target -- regex unnecessary.

clayborg updated this revision to Diff 296736.Oct 7 2020, 10:37 AM

Removed test cases that were only run if the architecture specific target is available.

This basically removes the testing for the original patch, since all of these tests would now pass even if the feature is completely reverted. Fortunately, I think the fix for that is easy. We don't need to add the regex to tests that already presuppose that the relevant llvm target is available. By the looks of things, that's everything except test/DebugInfo/dwarfdump-debug-frame-simple.test.

good catch. I have update the patch!

labath accepted this revision.Oct 7 2020, 10:44 AM
This revision is now accepted and ready to land.Oct 7 2020, 10:44 AM
This revision was landed with ongoing or failed builds.Oct 7 2020, 2:27 PM
This revision was automatically updated to reflect the committed changes.