Remove usages of special error reporting functions(error(),
reportError()). This patch is extracted from D87987.
Errors are reported as Expected<>/Error returning values.
This part is for MachO subfolder of llvm-objcopy.
Testing: check-all.
Differential D88113
[llvm-objcopy][NFC] refactor error handling. part 1. avl on Sep 22 2020, 1:19 PM. Authored by
Details Remove usages of special error reporting functions(error(), Testing: check-all.
Diff Detail
Event Timeline
Comment Actions Looks good from my point of view. Might be worth a second opinion (@grimar/@MaskRay/@rupprecht/@alexshap?) Comment Actions apart from the minor comments, I think this change is in the right direction.
|
nit: perhaps, I'd keep the old name of the variable (simply O) because ObjOrErr somehow appears to suggest that the type of this variable is ErrorOr<...> (https://llvm.org/doxygen/classllvm_1_1ErrorOr.html ) which is not the case.