Page MenuHomePhabricator

[NFC] [PPC] Add PowerPC expected IR tests for C99 complex
ClosedPublic

Authored by cebowleratibm on Sep 22 2020, 9:38 AM.

Details

Summary

Adding this test so that I can extend it in a follow on patch with expected IR for AIX when I implement complex handling in AIXABIInfo.

Diff Detail

Event Timeline

cebowleratibm created this revision.Sep 22 2020, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 9:38 AM
cebowleratibm requested review of this revision.Sep 22 2020, 9:38 AM
ZarkoCA added inline comments.Sep 22 2020, 10:41 AM
clang/test/CodeGen/powerpc-c99complex.c
2

Can you add ppc64le as well?

cebowleratibm marked an inline comment as done.

Added ppc64le target.

daltenty accepted this revision.Sep 23 2020, 7:03 AM

LGTM, thanks.

This revision is now accepted and ready to land.Sep 23 2020, 7:03 AM
ZarkoCA added inline comments.Sep 23 2020, 7:39 AM
clang/test/CodeGen/powerpc-c99complex.c
8

Nit: I don't think you need the #0 here and anywhere below.

20–21

Nit: please line up these lines with the ones below.

35–40

Nit: Can the formatting be fixed so the lines line up?

cebowleratibm marked 2 inline comments as done.

Reworked the prefixes and indentation.

ZarkoCA accepted this revision.Sep 23 2020, 8:13 PM

Thanks for doing the formatting changes.

This clearly changes behaviour and should thereby not have the [NFC] tag.

This clearly changes behaviour and should thereby not have the [NFC] tag.

Looks like it accidentally includes https://reviews.llvm.org/D88130.

Looks to me that this (since it is approved) completely replaces D88130. The patch description needs to be changed of course.
Not sure if the committer wants to try splitting out the non-AIX test as an NFC patch.

Off-list discussion seems to indicate that only the NFC portion of the patch was intended to be approved.
That is, the scope of this patch is supposed to be https://reviews.llvm.org/D88105?id=293625 plus formatting changes.

This revision was automatically updated to reflect the committed changes.