This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Linalg] Fix assertion in dependency analysis
ClosedPublic

Authored by frgossen on Sep 22 2020, 3:04 AM.

Details

Summary

The assertion falsely expected ranked memrefs only. Now both, ranked and
unranked memrefs are allowed.

Diff Detail

Event Timeline

frgossen created this revision.Sep 22 2020, 3:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2020, 3:04 AM
frgossen requested review of this revision.Sep 22 2020, 3:04 AM
pifon2a accepted this revision.Sep 22 2020, 3:05 AM
This revision is now accepted and ready to land.Sep 22 2020, 3:05 AM

What does it mean for a linalg op to take unranked memref?
In particular, a linalg op has indexing_maps. of fixed rank.
How would that work with unranked stuff ?

This revision was landed with ongoing or failed builds.Sep 22 2020, 3:21 AM
This revision was automatically updated to reflect the committed changes.

What does it mean for a linalg op to take unranked memref?
In particular, a linalg op has indexing_maps. of fixed rank.
How would that work with unranked stuff ?

I don't think it really takes unranked memref here. We have reshape op that changes descriptor from unranked to ranked and this op has ViewLikeOpInterface. But we hit this assert if we use the output of this op. Or maybe i am missing smth.