Paths

Table of Contentst

Differential D88043

[PowerPC] Add outer product instructions for MMA
ClosedPublic
Actions

Authored by saghir on Sep 21 2020, 1:49 PM.

Details

Reviewers

bsaleil
nemanjai
amyk

Group Reviewers

Restricted Project

Commits

rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA

Summary

This patch adds outer product instructions for MMA, including related infrastructure, and their tests.

Depends on D84968.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

saghir created this revision.Sep 21 2020, 1:49 PM

Herald added subscribers: llvm-commits, shchenz, kbarton, hiraditya. · View Herald TranscriptSep 21 2020, 1:49 PM

saghir requested review of this revision.Sep 21 2020, 1:49 PM

Harbormaster completed remote builds in B72420: Diff 293244.Sep 21 2020, 1:49 PM

saghir added a parent revision: D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.Sep 21 2020, 1:50 PM

saghir retitled this revision from [PowerPC] Add instruction definitions for MMA to [PowerPC] Add outer product instructions for MMA.Sep 21 2020, 1:52 PM

saghir edited the summary of this revision. (Show Details)

saghir edited the summary of this revision. (Show Details)

saghir edited the summary of this revision. (Show Details)

amyk added a subscriber: amyk.Sep 22 2020, 4:35 PM

amyk added inline comments.

llvm/lib/Target/PowerPC/PPCInstrPrefix.td
987	s/versioon/version
1302	s/aaccumlating/accumulating
llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s
35	This is minor (and may not matter), but maybe we can align the `# encoding` lines together.

Rebased after dependant patches were committed.

Harbormaster completed remote builds in B73338: Diff 294988.Sep 29 2020, 8:04 AM

LGTM, thanks. I think the patch can be committed once the typos are fixed.

This revision is now accepted and ready to land.Sep 29 2020, 11:14 AM

Fixed typos and indentation.

Harbormaster completed remote builds in B73398: Diff 295082.Sep 29 2020, 12:32 PM

LGTM.

Closed by commit rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA (authored by saghir). · Explain WhySep 30 2020, 4:07 PM

This revision was automatically updated to reflect the committed changes.

saghir added a commit: rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

PowerPC/

AsmParser/

PPCAsmParser.cpp

5 lines

Disassembler/

PPCDisassembler.cpp

9 lines

MCTargetDesc/

PPCMCCodeEmitter.h

3 lines

PPCMCCodeEmitter.cpp

10 lines

PPCInstrPrefix.td

513 lines

test/

MC/

Disassembler/

PowerPC/

ppc64-encoding-ISA31.txt

174 lines

PowerPC/

ppc64-encoding-ISA31.s

232 lines

Diff 295432

llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp

Loading...

llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp

Loading...

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.h

Loading...

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp

Loading...

llvm/lib/Target/PowerPC/PPCInstrPrefix.td

Loading...

llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-ISA31.txt

Loading...

llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s

Loading...