Page MenuHomePhabricator

[PowerPC] Add outer product instructions for MMA
ClosedPublic

Authored by saghir on Mon, Sep 21, 1:49 PM.

Details

Summary

This patch adds outer product instructions for MMA, including related infrastructure, and their tests.

Depends on D84968.

Diff Detail

Event Timeline

saghir created this revision.Mon, Sep 21, 1:49 PM
saghir requested review of this revision.Mon, Sep 21, 1:49 PM
saghir retitled this revision from [PowerPC] Add instruction definitions for MMA to [PowerPC] Add outer product instructions for MMA.Mon, Sep 21, 1:52 PM
saghir edited the summary of this revision. (Show Details)
saghir edited the summary of this revision. (Show Details)
saghir edited the summary of this revision. (Show Details)
amyk added a subscriber: amyk.Tue, Sep 22, 4:35 PM
amyk added inline comments.
llvm/lib/Target/PowerPC/PPCInstrPrefix.td
987

s/versioon/version

1302

s/aaccumlating/accumulating

llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s
35

This is minor (and may not matter), but maybe we can align the # encoding lines together.

saghir updated this revision to Diff 294988.Tue, Sep 29, 7:46 AM

Rebased after dependant patches were committed.

bsaleil accepted this revision.Tue, Sep 29, 11:14 AM

LGTM, thanks. I think the patch can be committed once the typos are fixed.

This revision is now accepted and ready to land.Tue, Sep 29, 11:14 AM
saghir updated this revision to Diff 295082.Tue, Sep 29, 12:11 PM

Fixed typos and indentation.

amyk accepted this revision.Tue, Sep 29, 1:57 PM

LGTM.

This revision was automatically updated to reflect the committed changes.