Page MenuHomePhabricator
Differential D88043

[PowerPC] Add outer product instructions for MMA
ClosedPublic
Actions

Authored by saghir on Mon, Sep 21, 1:49 PM.

Details

Reviewers
bsaleil
nemanjai
amyk
Group Reviewers
Restricted Project
Commits
rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA
Summary

This patch adds outer product instructions for MMA, including related infrastructure, and their tests.

Depends on D84968.

Diff Detail

Event Timeline

saghir created this revision.Mon, Sep 21, 1:49 PM
Herald added subscribers: llvm-commits, shchenz, kbarton, hiraditya. · View Herald TranscriptMon, Sep 21, 1:49 PM
saghir requested review of this revision.Mon, Sep 21, 1:49 PM
Harbormaster completed remote builds in B72420: Diff 293244.Mon, Sep 21, 1:49 PM
saghir added a parent revision: D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types.Mon, Sep 21, 1:50 PM
saghir retitled this revision from [PowerPC] Add instruction definitions for MMA to [PowerPC] Add outer product instructions for MMA.Mon, Sep 21, 1:52 PM
saghir edited the summary of this revision. (Show Details)
saghir edited the summary of this revision. (Show Details)
saghir edited the summary of this revision. (Show Details)
amyk added a subscriber: amyk.Tue, Sep 22, 4:35 PM
amyk added inline comments.
llvm/lib/Target/PowerPC/PPCInstrPrefix.td
987

s/versioon/version

1302

s/aaccumlating/accumulating

llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s
35

This is minor (and may not matter), but maybe we can align the # encoding lines together.

saghir updated this revision to Diff 294988.Tue, Sep 29, 7:46 AM

Rebased after dependant patches were committed.

Harbormaster completed remote builds in B73338: Diff 294988.Tue, Sep 29, 8:04 AM
bsaleil accepted this revision.Tue, Sep 29, 11:14 AM

LGTM, thanks. I think the patch can be committed once the typos are fixed.

This revision is now accepted and ready to land.Tue, Sep 29, 11:14 AM
saghir updated this revision to Diff 295082.Tue, Sep 29, 12:11 PM

Fixed typos and indentation.

Harbormaster completed remote builds in B73398: Diff 295082.Tue, Sep 29, 12:32 PM
amyk accepted this revision.Tue, Sep 29, 1:57 PM

LGTM.

Closed by commit rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA (authored by saghir). · Explain WhyWed, Sep 30, 4:07 PM
This revision was automatically updated to reflect the committed changes.
saghir added a commit: rG66d2e3f49594: [PowerPC] Add outer product instructions for MMA.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
PowerPC/
AsmParser/
5 lines
Disassembler/
9 lines
MCTargetDesc/
3 lines
10 lines
513 lines
test/
MC/
Disassembler/
PowerPC/
174 lines
PowerPC/
232 lines

Diff 295432

View Options

llvm/lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp

Loading...
View Options

llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp

Loading...
View Options

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.h

Loading...
View Options

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp

Loading...
View Options

llvm/lib/Target/PowerPC/PPCInstrPrefix.td

Loading...
View Options

llvm/test/MC/Disassembler/PowerPC/ppc64-encoding-ISA31.txt

Loading...
View Options

llvm/test/MC/PowerPC/ppc64-encoding-ISA31.s

Loading...