Page MenuHomePhabricator

[mlir] Shape.AssumingOp implements RegionBranchOpInterface.
ClosedPublic

Authored by tpopp on Sep 18 2020, 2:16 AM.

Details

Summary

This adds support for the interface and provides unambigious information
on the control flow as it is unconditional on any runtime values.
The code is tested through confirming that buffer-placement behaves as
expected.

Diff Detail

Event Timeline

tpopp created this revision.Sep 18 2020, 2:16 AM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
tpopp requested review of this revision.Sep 18 2020, 2:16 AM
tpopp added a comment.Sep 18 2020, 2:18 AM

Note that this is not complete and was uploaded at the current state to share a patch to reproduce a bug.

tpopp updated this revision to Diff 292757.Sep 18 2020, 5:04 AM

Update test case to pass by using previously unused value.

tpopp updated this revision to Diff 292758.Sep 18 2020, 5:06 AM

Add note to explain purpose of method.

tpopp added a comment.Sep 18 2020, 5:06 AM

Ready for review now.

herhut accepted this revision.Sep 18 2020, 5:33 AM

Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 21 2020, 2:33 AM
This revision was automatically updated to reflect the committed changes.