[ASTMatchers] Define clang::ast_matchers::decompositionDecl

[ro]

Summary

D87588 broke Debug builds on both Solaris/sparcv9 and Solaris/amd64:

[48/224] Linking CXX executable bin/clang-query
FAILED: bin/clang-query
[...]
Undefined                       first referenced
 symbol                             in file
_ZN5clang12ast_matchers17decompositionDeclE lib/libclangDynamicASTMatchers.a(Registry.cpp.o)
ld: fatal: symbol referencing errors

This doesn't happen for Release builds or x86_64-pc-linux-gnu Debug builds.

However, from comparison with e.g. linkageSpecDecl it's clear that the definition in clang/lib/ASTMatchers/ASTMatchersInternal.cpp is missing and indeed adding it allows the builds to complete.

[lebedev.ri]

SGTM, that's a pretty traditional issue.

[ro]

Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.

clang/lib/ASTMatchers/ASTMatchersInternal.cpp

const internal::VariadicDynCastAllOfMatcher<Decl, TranslationUnitDecl>
     translationUnitDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, TypedefDecl> typedefDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, TypedefNameDecl>
     typedefNameDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, TypeAliasDecl> typeAliasDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, TypeAliasTemplateDecl>
     typeAliasTemplateDecl;
 const internal::VariadicAllOfMatcher<Decl> decl;
+const internal::VariadicAllOfMatcher<DecompositionDecl> decompositionDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, LinkageSpecDecl>
     linkageSpecDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, NamedDecl> namedDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, LabelDecl> labelDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, NamespaceDecl> namespaceDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, NamespaceAliasDecl>
     namespaceAliasDecl;
 const internal::VariadicDynCastAllOfMatcher<Decl, RecordDecl> recordDecl;