Page MenuHomePhabricator

[ASTMatchers] Define clang::ast_matchers::decompositionDecl
AbandonedPublic

Authored by ro on Sep 17 2020, 4:07 AM.

Details

Summary

D87588 broke Debug builds on both Solaris/sparcv9 and Solaris/amd64:

[48/224] Linking CXX executable bin/clang-query
FAILED: bin/clang-query
[...]
Undefined                       first referenced
 symbol                             in file
_ZN5clang12ast_matchers17decompositionDeclE lib/libclangDynamicASTMatchers.a(Registry.cpp.o)
ld: fatal: symbol referencing errors

This doesn't happen for Release builds or x86_64-pc-linux-gnu Debug builds.

However, from comparison with e.g. linkageSpecDecl it's clear that the definition in clang/lib/ASTMatchers/ASTMatchersInternal.cpp is missing and indeed adding it allows the builds to complete.

Diff Detail

Event Timeline

ro created this revision.Sep 17 2020, 4:07 AM
ro requested review of this revision.Sep 17 2020, 4:07 AM
lebedev.ri accepted this revision.Sep 17 2020, 4:23 AM
lebedev.ri added a subscriber: lebedev.ri.

SGTM, that's a pretty traditional issue.

This revision is now accepted and ready to land.Sep 17 2020, 4:23 AM
ro abandoned this revision.Sep 17 2020, 4:31 AM

Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.