Page MenuHomePhabricator

[llvm-readobj] - Cleanup implementation LLVMStyle<ELFT>::printAddrsig().
ClosedPublic

Authored by grimar on Sep 11 2020, 4:44 AM.

Details

Summary

It has following issues:

  1. getStaticSymbolName returns std::string, but the code assigns a result to Expected<std::string>.
  2. The code uses unwrapOrError and never tests the error reported.

This patch fixes these issues.

Diff Detail

Event Timeline

grimar created this revision.Sep 11 2020, 4:44 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Sep 11 2020, 4:44 AM
MaskRay accepted this revision.Sep 11 2020, 11:02 PM

Looks great!

This revision is now accepted and ready to land.Sep 11 2020, 11:02 PM