Page MenuHomePhabricator

[Attributor] Disable the MustBeExecutedContext by default
AcceptedPublic

Authored by jdoerfert on Sep 9 2020, 10:17 PM.

Details

Summary

The MustBeExecutedContext is powerful but as of now we have no good way
to limit the creation of new AAs when traversing it. In order to get
compile time down we will disable the use of the MustBeExecutedContext
for now and revisit this once we have more control on the compile time
spend.

Tests are updated to run with the MBEC except MBEC.ll which runs with
and without.

Diff Detail

Unit TestsFailed

TimeTest
380 mslinux > LLVM.Transforms/OpenMP::parallel_deletion.ll
Script: -- : 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -S -attributor -openmpopt < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/OpenMP/parallel_deletion.ll | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/OpenMP/parallel_deletion.ll
340 mswindows > LLVM.Transforms/OpenMP::parallel_deletion.ll
Script: -- : 'RUN: at line 2'; c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\opt.exe -S -attributor -openmpopt < C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\Transforms\OpenMP\parallel_deletion.ll | c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\Transforms\OpenMP\parallel_deletion.ll

Event Timeline

jdoerfert created this revision.Sep 9 2020, 10:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 10:18 PM
jdoerfert requested review of this revision.Sep 9 2020, 10:18 PM
sstefan1 accepted this revision.Sep 9 2020, 11:50 PM

LGTM!

Looks like parallel_deletion.ll needs to be updated as well.

This revision is now accepted and ready to land.Sep 9 2020, 11:50 PM