Page MenuHomePhabricator

[llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues
ClosedPublic

Authored by mstorsjo on Sep 9 2020, 4:38 AM.

Details

Summary

This matches how e.g. stp/ldp and other opcodes are printed differently for epilogues.

Also add a missing --strict-whitespace in an existing test that was added explicitly for testing vertical alignment.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 9 2020, 4:38 AM
mstorsjo requested review of this revision.Sep 9 2020, 4:38 AM
efriedma accepted this revision.Sep 9 2020, 1:36 PM

LGTM

This revision is now accepted and ready to land.Sep 9 2020, 1:36 PM
MaskRay accepted this revision.Sep 9 2020, 2:00 PM

Also add a missing --strict-whitespace in an existing test that was added explicitly for testing vertical alignment.

Without --match-full-lines, leading and trailing space changes cannot be detected. For // CHECK: a b, you can ensure the spaces between a and b are 2, but you cannot test the indentation.

Also add a missing --strict-whitespace in an existing test that was added explicitly for testing vertical alignment.

Without --match-full-lines, leading and trailing space changes cannot be detected. For // CHECK: a b, you can ensure the spaces between a and b are 2, but you cannot test the indentation.

Yeah - here, --strict-whitespace is enough for the thing that the testcase wanted to test (the amount of spaces between the hex opcodes and their interpretation on the right hand side, which was fixed in D86523).