This is an archive of the discontinued LLVM Phabricator instance.

[Polly][NewPM] Port Simplify to the new pass manager
ClosedPublic

Authored by pzheng on Sep 8 2020, 2:16 PM.

Diff Detail

Event Timeline

pzheng created this revision.Sep 8 2020, 2:16 PM
Herald added a project: Restricted Project. · View Herald Transcript
pzheng requested review of this revision.Sep 8 2020, 2:16 PM

Could you add a test that invokes the pass with the new pass manage? E.g. take an existing test for the SimplifyPass, and add a RUN: line that does the same thing with NPM?

Thank you for the patch!

pzheng updated this revision to Diff 292985.Sep 19 2020, 12:59 PM

Thanks for reviewing the patch, @Meinersbur!

I have updated some of the existing tests for the SimplifyPass to also use the NPM. There are still some tests for SimplifyPass which depend on other Polly passes being properly ported first. Those tests will be updated in a follow-up patch.

pzheng updated this revision to Diff 292986.Sep 19 2020, 1:05 PM

minor update to a test

Meinersbur accepted this revision.Sep 20 2020, 5:57 PM

LGTM

A single test test file would be enough to check that the new pass manager pipeline is working. Checking all tests with both pass manager doubles the execution time for check-polly without improving test coverage. There are not too many tests for the simplify pass, but please consider testing it only once with the scalability tests, as these take the most time.

This revision is now accepted and ready to land.Sep 20 2020, 5:57 PM

LGTM

A single test test file would be enough to check that the new pass manager pipeline is working. Checking all tests with both pass manager doubles the execution time for check-polly without improving test coverage. There are not too many tests for the simplify pass, but please consider testing it only once with the scalability tests, as these take the most time.

That makes sense. I will revert changes in the scalability tests when committing.

This revision was landed with ongoing or failed builds.Sep 20 2020, 7:18 PM
This revision was automatically updated to reflect the committed changes.