Page MenuHomePhabricator

[IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions
AcceptedPublic

Authored by AndrewLitteken on Sep 8 2020, 11:28 AM.

Details

Reviewers
paquette
jroelofs
Summary

There are functions that the linker is able to automatically deduplicate, we do not outline from these functions by default. This allows for outlining from those functions.

Tests:

  • llvm/test/Transforms/IROutliner/outlining-odr.ll

Diff Detail

Event Timeline

AndrewLitteken created this revision.Sep 8 2020, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 11:28 AM
jroelofs added inline comments.
llvm/lib/Transforms/IPO/IROutliner.cpp
36

The comment seems to suggest that this ought to be set in the LTO pass pipeline, but that doesn't happen in this patch. Is this just for testing?

AndrewLitteken added inline comments.Sep 15 2020, 8:02 PM
llvm/lib/Transforms/IPO/IROutliner.cpp
36

For now, it is for testing, and we do hope to put the pass in LTO eventually.

This revision is now accepted and ready to land.Sep 16 2020, 8:12 AM