[IRSim][IROutliner] Allowing call instructions to be outlined.

[AndrewLitteken]

Summary

We add an extra check to make sure that we do not outline calls to indirect functions, but outline whatever the IRSimilarityIdentifier finds with respect to calls.

Tests:

• Removing test/Transforms/IROutliner/illegal-calls.ll
• Adding test/Transforms/IROutliner/outlining-calls.ll
• Adding test/Transforms/IROutliner/illegal-indirect-calls.ll

[jroelofs]

llvm/include/llvm/Transforms/IPO/IROutliner.h

324–331

I don't follow the logic behind needing a name for this to work. ISTM you could pass the callee pointer as another new arg, and everything else would Just Work (TM). What am I missing?

[AndrewLitteken]

llvm/include/llvm/Transforms/IPO/IROutliner.h

324–331

I don’t think you’re missing anything on that front. I just hadn’t considered writing it like that before. The same name just ensures that we are outlining the exact same function in both cases without any sort of argument handling, if it’s indirect, we can’t guarantee that.

However I think that it might be best to handle indirect calls in a separate patch later on since it adds a layer of complexity onto handling the arguments (see https://reviews.llvm.org/D87294 for an example of how it would be handled).

[jroelofs]

LGTM

llvm/include/llvm/Transforms/IPO/IROutliner.h

324–331

👍