- User Since
- Apr 9 2020, 6:03 PM (61 w, 4 d)
Update splitCandidates to escape early if the region cannot be extracted, and checking the boolean CandidateSplit for the region rather than using IgnoreRegion,
Sun, Jun 13
Fri, Jun 11
Remade tests with regexed metadata information.
Thu, Jun 10
Wed, Jun 9
Same for this one, can I merge this on behalf of @lanza?
If there are no objections, can I merge this on behalf of @lanza?
Just bumping this again, is this good to land?
Apr 8 2021
I think with the generalization this should be good to try to land again?
Is this good to land then?
Mar 22 2021
Updating message for the failure case where the file does not exist to be platform agnostic.
Visual Studios Standard library starts their errors in lower case, which do not match the hardcoded values you used in your tests. Take a look at the lit feature added here https://reviews.llvm.org/rGc52fe0b02172e707aa2ba38cd2e01a1fc70dd0da, you should be able to use it to expand to the correct platform specific error message
There's a bug with one of the Windows buildbots where the error message doesn't match (even though it looks like it does), but I haven't quite been able to figure out why it's failing yet. I think it has something do to with the fact that it's reporting an error, and that there is a FileCheck prefix.
Mar 20 2021
Feb 9 2021
Feb 1 2021
@vsk Is there other verification that needs to happen to the outlined IR code besides just making sure with Filecheck that it is correct?
Jan 20 2021
With the nit about the comment this LGTM
Jan 14 2021
This looks fine to me, just one small nit in getBenefit for consistency with the rest of the patch.
Jan 13 2021
Jan 8 2021
This updates the diff with all the recent IROutliner updates, and adds testing for verifying the IR DebugInfo.
Jan 3 2021
Jan 1 2021
Dec 31 2020
I reverted this commit because it was causing problems with clang on several of the buildbots with the general flavor of the following error log:
Dec 30 2020
Dec 29 2020
Dec 28 2020
Dec 23 2020
Dec 19 2020
The URL was not included in commit message for 5cdc4f57e50bbe0d211c109517c17defe78e0b73. Closing manually.
Dec 17 2020
Dec 2 2020
Updating an incorrect typo introduced from the fix-up patch.
These are updates to try to fix the build problem of the llvm-sim executable not being found for tests on Windows and some Linux builds. Unfortunately, I do not have the errors anymore. Is there something else that will need added to add llvm-sim as a tool? The changes I've made reflect what I've found has been done for other tools.