Page MenuHomePhabricator

AndrewLitteken (Andrew Litteken)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 6:03 PM (28 w, 2 d)

Recent Activity

Wed, Sep 30

AndrewLitteken updated the diff for D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..

Fixing an extra addition that fell out of refactoring causing overestimates in the number of instructions outlined.

Wed, Sep 30, 11:29 AM · Restricted Project

Sep 25 2020

AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Updating LLVMBuild.txt as well.

Sep 25 2020, 2:53 PM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Fixing CMakeLists.txt to accurately reflect what needs to be linked, and flags and redirection for the tests themselves.

Sep 25 2020, 2:42 PM · Restricted Project
AndrewLitteken added a reverting change for rG15645d044bcf: [IRSim] Adding basic implementation of llvm-sim.: rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Sep 25 2020, 2:19 PM
AndrewLitteken committed rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim." (authored by AndrewLitteken).
Revert "[IRSim] Adding basic implementation of llvm-sim."
Sep 25 2020, 2:19 PM
AndrewLitteken added a reverting change for D86974: [IRSim] Adding basic implementation of llvm-sim.: rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Sep 25 2020, 2:19 PM · Restricted Project
AndrewLitteken committed rG15645d044bcf: [IRSim] Adding basic implementation of llvm-sim. (authored by AndrewLitteken).
[IRSim] Adding basic implementation of llvm-sim.
Sep 25 2020, 1:25 PM
AndrewLitteken closed D86974: [IRSim] Adding basic implementation of llvm-sim..
Sep 25 2020, 1:25 PM · Restricted Project

Sep 24 2020

AndrewLitteken committed rGf02c4c87b46c: [IRSim] Adding wrapper pass for IRSimilarityIdentfier (authored by AndrewLitteken).
[IRSim] Adding wrapper pass for IRSimilarityIdentfier
Sep 24 2020, 1:00 PM
AndrewLitteken closed D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Sep 24 2020, 12:59 PM · Restricted Project
AndrewLitteken committed rG08d145e6d7a9: [IRSim][NFC] Removing dead variables from IRSimilarityIdentifier.cpp (authored by AndrewLitteken).
[IRSim][NFC] Removing dead variables from IRSimilarityIdentifier.cpp
Sep 24 2020, 9:44 AM
AndrewLitteken added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 7:57 AM · Restricted Project
AndrewLitteken committed rGb63bfc2030de: [IRSim] Adding a basic similarity identifier. (authored by AndrewLitteken).
[IRSim] Adding a basic similarity identifier.
Sep 24 2020, 12:13 AM
AndrewLitteken closed D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 12:13 AM · Restricted Project

Sep 23 2020

AndrewLitteken committed rGbeeceb92c082: [IRSim][NFC] Removing warning from IRSimilarityIdentifier (authored by AndrewLitteken).
[IRSim][NFC] Removing warning from IRSimilarityIdentifier
Sep 23 2020, 10:39 PM
AndrewLitteken committed rGd1aa143aa84e: [IRSim] Adding structural comparison to IRSimilarityCandidate. (authored by AndrewLitteken).
[IRSim] Adding structural comparison to IRSimilarityCandidate.
Sep 23 2020, 8:43 PM
AndrewLitteken added a reverting change for rGb27db2bb6816: [IRSim] Adding structural comparison to IRSimilarityCandidate.: rG0a8e097e72df: Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate.".
Sep 23 2020, 8:43 PM
AndrewLitteken committed rG0a8e097e72df: Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate." (authored by AndrewLitteken).
Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate."
Sep 23 2020, 8:43 PM
AndrewLitteken closed D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..
Sep 23 2020, 8:43 PM · Restricted Project
AndrewLitteken committed rGb27db2bb6816: [IRSim] Adding structural comparison to IRSimilarityCandidate. (authored by AndrewLitteken).
[IRSim] Adding structural comparison to IRSimilarityCandidate.
Sep 23 2020, 8:31 PM
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Updating based on previous patches.

Sep 23 2020, 1:39 PM · Restricted Project
AndrewLitteken updated the diff for D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

Updating based on previous changes.

Sep 23 2020, 1:38 PM · Restricted Project
AndrewLitteken updated the diff for D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.

Updating to reflect other patches.

Sep 23 2020, 1:38 PM · Restricted Project
AndrewLitteken updated the diff for D86978: [IROutliner] Deduplicating functions that only require inputs..

Updating to reflect other patches.

Sep 23 2020, 1:37 PM · Restricted Project
AndrewLitteken updated the diff for D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.

Updating based on comments.

Sep 23 2020, 1:37 PM · Restricted Project
AndrewLitteken updated the diff for D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..

Updating for whitespace commits.

Sep 23 2020, 1:36 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Removing dead variable.

Sep 23 2020, 1:35 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Fixing some small nits.

Sep 23 2020, 1:16 PM · Restricted Project
AndrewLitteken committed rG6ada9e516f49: [IRSim] Adding IRSimilarityCandidate that contains a region of… (authored by AndrewLitteken).
[IRSim] Adding IRSimilarityCandidate that contains a region of…
Sep 23 2020, 11:44 AM
AndrewLitteken updated the diff for D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.
Sep 23 2020, 7:14 AM · Restricted Project
AndrewLitteken updated the diff for D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.

Updating diff to fix memory issues.

Sep 23 2020, 12:01 AM · Restricted Project

Sep 22 2020

AndrewLitteken added a reverting change for rG4944bb190fed: [IRSim] Adding IRSimilarityCandidate that contains a region of…: rG88bc59c3001b: Revert "[IRSim] Adding IRSimilarityCandidate that contains a region of….
Sep 22 2020, 7:04 PM
AndrewLitteken committed rG88bc59c3001b: Revert "[IRSim] Adding IRSimilarityCandidate that contains a region of… (authored by AndrewLitteken).
Revert "[IRSim] Adding IRSimilarityCandidate that contains a region of…
Sep 22 2020, 7:04 PM
AndrewLitteken added a reverting change for D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData: rG88bc59c3001b: Revert "[IRSim] Adding IRSimilarityCandidate that contains a region of….
Sep 22 2020, 7:04 PM · Restricted Project
AndrewLitteken added a comment to D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.

I believe this is causing issues in Windows builds, e.g. http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/25705 and hangs in http://45.33.8.238/win/summary.html.
I'm seeing a hang locally:
$ ./build/debug/obj/llvm/unittests/Analysis/AnalysisTests.exe --gtest_filter='*IRSimilarityCandidate.IdenticalWithDebug*'
Note: Google Test filter = *IRSimilarityCandidate.IdenticalWithDebug*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from IRSimilarityCandidate
[ RUN ] IRSimilarityCandidate.IdenticalWithDebug
warning: ignoring debug info with an invalid version (0) in <string>

and then it hangs

Sep 22 2020, 7:03 PM · Restricted Project
AndrewLitteken committed rG4944bb190fed: [IRSim] Adding IRSimilarityCandidate that contains a region of… (authored by AndrewLitteken).
[IRSim] Adding IRSimilarityCandidate that contains a region of…
Sep 22 2020, 4:42 PM
AndrewLitteken closed D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.
Sep 22 2020, 4:42 PM · Restricted Project

Sep 18 2020

AndrewLitteken updated the diff for D86972: [IRSim] Adding a basic similarity identifier..

I'm not sure what happened, but I uploaded the entirely wrong diff last time. This is the similarity identifier with the optional changes.

Sep 18 2020, 10:40 PM · Restricted Project
AndrewLitteken added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Sep 18 2020, 10:31 PM · Restricted Project
AndrewLitteken committed rG132aaec4f27e: [IRSim] Adding ilist for IRInstructionData. (authored by AndrewLitteken).
[IRSim] Adding ilist for IRInstructionData.
Sep 18 2020, 10:19 PM
AndrewLitteken closed D86969: [IRSim] Adding ilist for IRInstructionData.
Sep 18 2020, 10:19 PM · Restricted Project
AndrewLitteken added a comment to D86978: [IROutliner] Deduplicating functions that only require inputs..

A lot of the dead variables belong to future patches, I'll make sure to weed them out in the next diff.

Sep 18 2020, 5:02 PM · Restricted Project

Sep 17 2020

AndrewLitteken updated the diff for D86972: [IRSim] Adding a basic similarity identifier..

Updating optional handling.

Sep 17 2020, 3:23 PM · Restricted Project
AndrewLitteken updated the diff for D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.

Updating optional handling

Sep 17 2020, 3:22 PM · Restricted Project
AndrewLitteken added inline comments to D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Sep 17 2020, 1:53 PM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Excluding debug instructions, and updating how we add to the DenseMap.

Sep 17 2020, 1:44 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Different handling of getSimilarity() to handle optionals.

Sep 17 2020, 1:42 PM · Restricted Project
AndrewLitteken added inline comments to D86974: [IRSim] Adding basic implementation of llvm-sim..
Sep 17 2020, 1:41 PM · Restricted Project
AndrewLitteken updated the diff for D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.

Updating for the new Optional in IRSimilarityIdentifier.

Sep 17 2020, 1:38 PM · Restricted Project
AndrewLitteken updated the diff for D86972: [IRSim] Adding a basic similarity identifier..

Updating flag for SimilarityCandidates to an Optional.

Sep 17 2020, 1:32 PM · Restricted Project
AndrewLitteken committed rG7e4c6fb85466: [IRSim] Adding IR Instruction Mapper (authored by AndrewLitteken).
[IRSim] Adding IR Instruction Mapper
Sep 17 2020, 12:09 PM
AndrewLitteken updated the diff for D86969: [IRSim] Adding ilist for IRInstructionData.

Updating to add the SpecificBumpAllocator for the IRInstructionDataList.

Sep 17 2020, 11:50 AM · Restricted Project
AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.

Updating to use SpecificBumpAllocator instead, to get rid of memory leaks.

Sep 17 2020, 11:02 AM · Restricted Project
AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.

Updating hash_value, hash_combine calls with namespace specification for Windows buildbots, and explicitly deleting OperVals from IRInstructionData to fix a memory leak.

Sep 17 2020, 7:19 AM · Restricted Project

Sep 16 2020

AndrewLitteken committed rGb04c1a9d3127: [IRSim] Adding IR Instruction Mapper (authored by AndrewLitteken).
[IRSim] Adding IR Instruction Mapper
Sep 16 2020, 6:49 PM
AndrewLitteken closed D86968: [IRSim] Adding IR Instruction Mapper.
Sep 16 2020, 6:49 PM · Restricted Project
AndrewLitteken updated the diff for D87311: [IRSim] Adding commutativity matching to structure checking.

Updating to reflect changes in https://reviews.llvm.org/D86971.

Sep 16 2020, 2:31 PM · Restricted Project
AndrewLitteken updated the diff for D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

Updating to reduce complexity of function call.

Sep 16 2020, 2:29 PM · Restricted Project
AndrewLitteken added inline comments to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..
Sep 16 2020, 9:43 AM · Restricted Project

Sep 15 2020

AndrewLitteken updated the diff for D87301: [IRSim][IROutliner] Adding consistent function attribute merging.
Sep 15 2020, 10:18 PM · Restricted Project
AndrewLitteken updated the summary of D87742: [IROutliner] Adding support for swift errors.
Sep 15 2020, 10:08 PM · Restricted Project
AndrewLitteken requested review of D87742: [IROutliner] Adding support for swift errors.
Sep 15 2020, 10:08 PM · Restricted Project
AndrewLitteken added inline comments to D87301: [IRSim][IROutliner] Adding consistent function attribute merging.
Sep 15 2020, 10:05 PM · Restricted Project
AndrewLitteken updated the diff for D87310: [IRSim] Adding support for isomorphic predicates.

A few things changed just enough since OperTypes was removed, so updating the diff to reflect this.

Sep 15 2020, 9:39 PM · Restricted Project
AndrewLitteken updated the diff for D87301: [IRSim][IROutliner] Adding consistent function attribute merging.

Updating function attribute handling to use existing functions.

Sep 15 2020, 9:36 PM · Restricted Project
AndrewLitteken updated the diff for D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

Updating for string refs.

Sep 15 2020, 9:35 PM · debug-info, Restricted Project
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Updating comments and Optional handling

Sep 15 2020, 9:34 PM · Restricted Project
AndrewLitteken updated the diff for D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

Rejiggering the rickety double-iteration to collect the instructions separately.

Sep 15 2020, 9:34 PM · Restricted Project
AndrewLitteken updated the diff for D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.

Updating comments.

Sep 15 2020, 9:33 PM · Restricted Project
AndrewLitteken updated the diff for D86978: [IROutliner] Deduplicating functions that only require inputs..

Updating diff to reflect changes in other patches.

Sep 15 2020, 9:32 PM · Restricted Project
AndrewLitteken updated the diff for D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.

Updating to reflect changes in other patches.

Sep 15 2020, 9:31 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Vector use cleanup.

Sep 15 2020, 9:30 PM · Restricted Project
AndrewLitteken updated the diff for D86972: [IRSim] Adding a basic similarity identifier..

Updating for explicit and for ArrayRef.

Sep 15 2020, 9:29 PM · Restricted Project
AndrewLitteken updated the diff for D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

Updating iterator use.

Sep 15 2020, 9:28 PM · Restricted Project
AndrewLitteken updated the diff for D86970: [IRSim] Adding IRSimilarityCandidate that contains a region of IRInstructionData.

Updating utility functions.

Sep 15 2020, 9:27 PM · Restricted Project
AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.

Updating comments.

Sep 15 2020, 9:26 PM · Restricted Project
AndrewLitteken added inline comments to D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.
Sep 15 2020, 8:02 PM · Restricted Project
AndrewLitteken added inline comments to D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Sep 15 2020, 4:15 PM · Restricted Project
AndrewLitteken added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Sep 15 2020, 4:11 PM · Restricted Project
AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.

Sorry for second diff so fast, forgot to update some of the parameter names in the comments.

Sep 15 2020, 2:22 PM · Restricted Project
AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.

Updating for simplicity, typos, and reducing redundant data structures.

Sep 15 2020, 1:59 PM · Restricted Project
AndrewLitteken added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 1:13 PM · Restricted Project
AndrewLitteken added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 11:56 AM · Restricted Project
AndrewLitteken added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 11:45 AM · Restricted Project
AndrewLitteken added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 11:32 AM · Restricted Project
AndrewLitteken added inline comments to D86968: [IRSim] Adding IR Instruction Mapper.
Sep 15 2020, 11:29 AM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Reorganization, and implication of string handling.

Sep 15 2020, 7:36 AM · Restricted Project
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Moving findDuplicateBlock to this diff.

Sep 15 2020, 7:29 AM · Restricted Project
AndrewLitteken updated the diff for D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

Updating for comments. Also removed function from this diff to the next since it was not used here.

Sep 15 2020, 7:28 AM · Restricted Project
AndrewLitteken updated the diff for D87312: [IRSim] Letting call instructions be legal for similarity identification..

Helper functions and nullptr checking for Call Instructions.

Sep 15 2020, 7:22 AM · Restricted Project

Sep 14 2020

AndrewLitteken added inline comments to D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..
Sep 14 2020, 6:07 PM · Restricted Project
AndrewLitteken updated the diff for D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

Removing uses of std::set.

Sep 14 2020, 3:28 PM · Restricted Project
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Removing std::set usage.

Sep 14 2020, 3:25 PM · Restricted Project
AndrewLitteken updated the diff for D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

Updating SmallVectors to ArrayRefs, related to comment by @jroelofs in https://reviews.llvm.org/D87311.

Sep 14 2020, 10:57 AM · Restricted Project
AndrewLitteken updated the diff for D87311: [IRSim] Adding commutativity matching to structure checking.

Changing some SmallVectors to ArrayRefs.

Sep 14 2020, 10:55 AM · Restricted Project
AndrewLitteken updated the diff for D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..

Updating for function_refs, llvm::interleave and capitalization.

Sep 14 2020, 10:54 AM · Restricted Project
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Updating comments for why we are using std::set instead of DenseSets.

Sep 14 2020, 10:53 AM · Restricted Project
AndrewLitteken added inline comments to D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..
Sep 14 2020, 10:11 AM · Restricted Project

Sep 8 2020

AndrewLitteken updated the diff for D86968: [IRSim] Adding IR Instruction Mapper.
Sep 8 2020, 3:11 PM · Restricted Project
AndrewLitteken updated subscribers of D86968: [IRSim] Adding IR Instruction Mapper.

ping @efriedma @craig.topper @MatzeB as potential reviewers for IR Similarity/Outliner passes.

Sep 8 2020, 1:08 PM · Restricted Project