Page MenuHomePhabricator

AndrewLitteken (Andrew Litteken)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 6:03 PM (61 w, 4 d)

Recent Activity

Today

AndrewLitteken committed rG2c21278e7471: [IROutliner] Adding DebugInfo handling for IR Outlined Functions (authored by AndrewLitteken).
[IROutliner] Adding DebugInfo handling for IR Outlined Functions
Tue, Jun 15, 8:58 AM
AndrewLitteken closed D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
Tue, Jun 15, 8:58 AM · debug-info, Restricted Project
AndrewLitteken added inline comments to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
Tue, Jun 15, 8:12 AM · debug-info, Restricted Project

Yesterday

AndrewLitteken updated the diff for D104142: [IROutliner] Ensure instructions at end of candidate are excluded.

Update splitCandidates to escape early if the region cannot be extracted, and checking the boolean CandidateSplit for the region rather than using IgnoreRegion,

Mon, Jun 14, 9:41 AM · Restricted Project
AndrewLitteken added inline comments to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
Mon, Jun 14, 8:16 AM · debug-info, Restricted Project
AndrewLitteken updated the diff for D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
Mon, Jun 14, 8:16 AM · debug-info, Restricted Project

Sun, Jun 13

AndrewLitteken added inline comments to D104142: [IROutliner] Ensure instructions at end of candidate are excluded.
Sun, Jun 13, 3:01 PM · Restricted Project

Fri, Jun 11

AndrewLitteken committed rGf6dea2e7328b: [IRSim] Strip out the findSimilarity call from the constructor (authored by AndrewLitteken).
[IRSim] Strip out the findSimilarity call from the constructor
Fri, Jun 11, 4:41 PM
AndrewLitteken closed D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor.
Fri, Jun 11, 4:41 PM · Restricted Project
AndrewLitteken committed rG64720f57bea6: [IRSim] Don't copy the Mapper for createCandidatesFromSuffixTree (authored by AndrewLitteken).
[IRSim] Don't copy the Mapper for createCandidatesFromSuffixTree
Fri, Jun 11, 2:52 PM
AndrewLitteken added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

This seems to break tests everywhere, eg http://45.33.8.238/linux/48721/step_12.txt

Please take a look and revert for now if it takes a while to fix.

Fri, Jun 11, 1:56 PM · Restricted Project
AndrewLitteken added a reverting change for rGf47d00c54b52: [IRSim] Adding basic implementation of llvm-sim.: rG8bc0eb401165: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Fri, Jun 11, 1:45 PM
AndrewLitteken committed rG8bc0eb401165: Revert "[IRSim] Adding basic implementation of llvm-sim." (authored by AndrewLitteken).
Revert "[IRSim] Adding basic implementation of llvm-sim."
Fri, Jun 11, 1:45 PM
AndrewLitteken added a reverting change for D86974: [IRSim] Adding basic implementation of llvm-sim.: rG8bc0eb401165: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Fri, Jun 11, 1:45 PM · Restricted Project
AndrewLitteken committed rGf47d00c54b52: [IRSim] Adding basic implementation of llvm-sim. (authored by AndrewLitteken).
[IRSim] Adding basic implementation of llvm-sim.
Fri, Jun 11, 1:04 PM
AndrewLitteken added a reviewer for D104142: [IROutliner] Ensure instructions at end of candidate are excluded: paquette.
Fri, Jun 11, 12:11 PM · Restricted Project
AndrewLitteken added a reviewer for D104143: [IRSim][IROutliner] Canonicalizing commutative value numbering between similarity sections.: paquette.
Fri, Jun 11, 12:11 PM · Restricted Project
AndrewLitteken requested review of D104143: [IRSim][IROutliner] Canonicalizing commutative value numbering between similarity sections..
Fri, Jun 11, 12:05 PM · Restricted Project
AndrewLitteken requested review of D104142: [IROutliner] Ensure instructions at end of candidate are excluded.
Fri, Jun 11, 12:00 PM · Restricted Project
AndrewLitteken updated the diff for D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

Remade tests with regexed metadata information.

Fri, Jun 11, 9:52 AM · debug-info, Restricted Project

Thu, Jun 10

AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

I guess this will need something like that -- on both MIR and IR versions of the pass. Any thoughts about this?

Thu, Jun 10, 8:29 AM · debug-info, Restricted Project

Wed, Jun 9

AndrewLitteken added a comment to D92532: [IRSimilarity] Don't copy the Mapper for createCandidatesFromSuffixTree.

Same for this one, can I merge this on behalf of @lanza?

Wed, Jun 9, 8:02 AM · Restricted Project
AndrewLitteken added a comment to D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor.

If there are no objections, can I merge this on behalf of @lanza?

Wed, Jun 9, 8:01 AM · Restricted Project
AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

Just bumping this again, is this good to land?

Wed, Jun 9, 8:00 AM · debug-info, Restricted Project

Apr 8 2021

AndrewLitteken added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

I think with the generalization this should be good to try to land again?

Apr 8 2021, 10:26 AM · Restricted Project
AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

Is this good to land then?

Apr 8 2021, 10:25 AM · debug-info, Restricted Project

Mar 22 2021

AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Updating message for the failure case where the file does not exist to be platform agnostic.

Mar 22 2021, 12:03 PM · Restricted Project
AndrewLitteken added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

Visual Studios Standard library starts their errors in lower case, which do not match the hardcoded values you used in your tests. Take a look at the lit feature added here https://reviews.llvm.org/rGc52fe0b02172e707aa2ba38cd2e01a1fc70dd0da, you should be able to use it to expand to the correct platform specific error message

Mar 22 2021, 11:16 AM · Restricted Project
AndrewLitteken added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

There's a bug with one of the Windows buildbots where the error message doesn't match (even though it looks like it does), but I haven't quite been able to figure out why it's failing yet. I think it has something do to with the fact that it's reporting an error, and that there is a FileCheck prefix.

Mar 22 2021, 9:51 AM · Restricted Project

Mar 20 2021

AndrewLitteken added a reverting change for rG5155dff2784a: [IRSim] Adding basic implementation of llvm-sim.: rG0776eca7a4e7: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Mar 20 2021, 4:03 PM
AndrewLitteken committed rG0776eca7a4e7: Revert "[IRSim] Adding basic implementation of llvm-sim." (authored by AndrewLitteken).
Revert "[IRSim] Adding basic implementation of llvm-sim."
Mar 20 2021, 4:03 PM
AndrewLitteken added a reverting change for D86974: [IRSim] Adding basic implementation of llvm-sim.: rG0776eca7a4e7: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Mar 20 2021, 4:03 PM · Restricted Project
AndrewLitteken committed rG5155dff2784a: [IRSim] Adding basic implementation of llvm-sim. (authored by AndrewLitteken).
[IRSim] Adding basic implementation of llvm-sim.
Mar 20 2021, 2:48 PM

Feb 9 2021

AndrewLitteken committed rG56615a2654ce: [IROutliner] Adding instruction strings to IRSimilarityPrinting diagnostics. (authored by AndrewLitteken).
[IROutliner] Adding instruction strings to IRSimilarityPrinting diagnostics.
Feb 9 2021, 10:12 AM
AndrewLitteken closed D94304: Updating the IRSimilarityPrinting Pass to include the first and last instruction.
Feb 9 2021, 10:12 AM · Restricted Project

Feb 1 2021

AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

@vsk Is there other verification that needs to happen to the outlined IR code besides just making sure with Filecheck that it is correct?

Feb 1 2021, 7:42 AM · debug-info, Restricted Project

Jan 20 2021

AndrewLitteken accepted D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor.

With the nit about the comment this LGTM

Jan 20 2021, 6:51 PM · Restricted Project

Jan 14 2021

AndrewLitteken added a comment to D94427: [NFC][InstructionCost] Use InstructionCost in lib/Transforms/IPO/IROutliner.cpp.

This looks fine to me, just one small nit in getBenefit for consistency with the rest of the patch.

Jan 14 2021, 11:09 AM · Restricted Project

Jan 13 2021

AndrewLitteken committed rG05b1a15f703c: [IROutliner] Adapting to hoisted bitcasts in CodeExtractor (authored by AndrewLitteken).
[IROutliner] Adapting to hoisted bitcasts in CodeExtractor
Jan 13 2021, 9:11 AM
AndrewLitteken closed D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Jan 13 2021, 9:11 AM · Restricted Project

Jan 8 2021

AndrewLitteken requested review of D94304: Updating the IRSimilarityPrinting Pass to include the first and last instruction.
Jan 8 2021, 6:37 AM · Restricted Project
AndrewLitteken retitled D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner from Adapting to hoisted bitcasts in CodeExtractor to Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Jan 8 2021, 6:35 AM · Restricted Project
AndrewLitteken requested review of D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Jan 8 2021, 6:34 AM · Restricted Project
AndrewLitteken updated the diff for D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

This updates the diff with all the recent IROutliner updates, and adds testing for verifying the IR DebugInfo.

Jan 8 2021, 6:33 AM · debug-info, Restricted Project

Jan 3 2021

AndrewLitteken committed rG5c951623bc89: [IROutliner] Refactoring errors in the cost model from past patches. (authored by AndrewLitteken).
[IROutliner] Refactoring errors in the cost model from past patches.
Jan 3 2021, 10:13 PM
AndrewLitteken committed rG05e6ac4eb811: [IROutliner] Removing a duplicate addition, causing overestimates in IROutliner. (authored by AndrewLitteken).
[IROutliner] Removing a duplicate addition, causing overestimates in IROutliner.
Jan 3 2021, 9:38 PM

Jan 1 2021

AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
In D87302#2277131, @vsk wrote:

CodeExtractor contains a utility to fix up debug info after extraction occurs (I believe it's called fixupDebugInfoPostExtraction). It's solving the same problem - is there any way to generalize/reuse that logic?

Jan 1 2021, 1:28 PM · debug-info, Restricted Project

Dec 31 2020

AndrewLitteken committed rG57a46914f5c1: [IRSim][IROutliner] Allowing call instructions to be outlined. (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing call instructions to be outlined.
Dec 31 2020, 9:30 PM
AndrewLitteken closed D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..
Dec 31 2020, 9:30 PM · Restricted Project
AndrewLitteken committed rG0d21e66014fc: [IRSim] Letting call instructions be legal for similarity identification. (authored by AndrewLitteken).
[IRSim] Letting call instructions be legal for similarity identification.
Dec 31 2020, 6:55 PM
AndrewLitteken closed D87312: [IRSim] Letting call instructions be legal for similarity identification..
Dec 31 2020, 6:55 PM · Restricted Project
AndrewLitteken committed rGb6b1006f0719: [IRSim][IROutliner] Allowing GEP instructions to be outlined. (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing GEP instructions to be outlined.
Dec 31 2020, 3:19 PM
AndrewLitteken closed D87317: [IRSim][IROutliner] Allowing GEP instructions to be outlined..
Dec 31 2020, 3:19 PM · Restricted Project
AndrewLitteken added a comment to rGa2513cb8655e: remove pessimizing moves (reported by gcc 10).

I reverted this commit because it was causing problems with clang on several of the buildbots with the general flavor of the following error log:

Dec 31 2020, 1:37 PM
AndrewLitteken added a reverting change for rGa2513cb8655e: remove pessimizing moves (reported by gcc 10): rG14dc69b09218: Revert "remove pessimizing moves (reported by gcc 10)".
Dec 31 2020, 1:16 PM
AndrewLitteken committed rG14dc69b09218: Revert "remove pessimizing moves (reported by gcc 10)" (authored by AndrewLitteken).
Revert "remove pessimizing moves (reported by gcc 10)"
Dec 31 2020, 1:16 PM
AndrewLitteken closed D87315: [IRSim] Letting gep instructions be legal for similarity identification..
Dec 31 2020, 12:43 PM · Restricted Project
AndrewLitteken committed rGd974ac0224de: [IRSim] Letting gep instructions be legal for similarity identification. (authored by AndrewLitteken).
[IRSim] Letting gep instructions be legal for similarity identification.
Dec 31 2020, 12:42 PM
AndrewLitteken committed rG1a9eb19af9ba: [IROutliner] Adding consistent function attribute merging (authored by AndrewLitteken).
[IROutliner] Adding consistent function attribute merging
Dec 31 2020, 10:31 AM
AndrewLitteken closed D87301: [IRSim][IROutliner] Adding consistent function attribute merging.
Dec 31 2020, 10:30 AM · Restricted Project

Dec 30 2020

AndrewLitteken committed rGfe431103b633: [IROutliner] Adding option to enable outlining from linkonceodr functions (authored by AndrewLitteken).
[IROutliner] Adding option to enable outlining from linkonceodr functions
Dec 30 2020, 10:20 AM
AndrewLitteken closed D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.
Dec 30 2020, 10:20 AM · Restricted Project

Dec 29 2020

AndrewLitteken committed rG30feb93036eb: [IROutliner] Adding support for swift errors in the IROutliner (authored by AndrewLitteken).
[IROutliner] Adding support for swift errors in the IROutliner
Dec 29 2020, 11:18 PM
AndrewLitteken added a reverting change for rG71867ed5e660: [IROutliner] Adding support for swift errors: rGeeb99c2ac267: Revert "[IROutliner] Adding support for swift errors".
Dec 29 2020, 11:18 PM
AndrewLitteken committed rGeeb99c2ac267: Revert "[IROutliner] Adding support for swift errors" (authored by AndrewLitteken).
Revert "[IROutliner] Adding support for swift errors"
Dec 29 2020, 11:17 PM
AndrewLitteken closed D87742: [IROutliner] Adding support for swift errors.
Dec 29 2020, 11:17 PM · Restricted Project
AndrewLitteken committed rG71867ed5e660: [IROutliner] Adding support for swift errors (authored by AndrewLitteken).
[IROutliner] Adding support for swift errors
Dec 29 2020, 11:15 PM
AndrewLitteken committed rGdf4a931c63b6: [IROutliner] Adding OptRemarks to the IROutliner Pass (authored by AndrewLitteken).
[IROutliner] Adding OptRemarks to the IROutliner Pass
Dec 29 2020, 1:53 PM
AndrewLitteken closed D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..
Dec 29 2020, 1:52 PM · Restricted Project
AndrewLitteken committed rG6df161a2fbf6: [IROutliner] Adding a cost model, and debug option to turn the model off. (authored by AndrewLitteken).
[IROutliner] Adding a cost model, and debug option to turn the model off.
Dec 29 2020, 10:44 AM
AndrewLitteken closed D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..
Dec 29 2020, 10:43 AM · Restricted Project

Dec 28 2020

AndrewLitteken committed rG1e23802507d1: [IROutliner] Merging identical output blocks for extracted functions. (authored by AndrewLitteken).
[IROutliner] Merging identical output blocks for extracted functions.
Dec 28 2020, 7:17 PM
AndrewLitteken closed D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Dec 28 2020, 7:17 PM · Restricted Project
AndrewLitteken committed rGe6ae623314ba: [IROutliner] Adding support for consolidating functions with different output… (authored by AndrewLitteken).
[IROutliner] Adding support for consolidating functions with different output…
Dec 28 2020, 2:17 PM
AndrewLitteken closed D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Dec 28 2020, 2:17 PM · Restricted Project

Dec 23 2020

AndrewLitteken committed rG48ad8194a56f: [IRSim] Adding support for isomorphic predicates (authored by AndrewLitteken).
[IRSim] Adding support for isomorphic predicates
Dec 23 2020, 5:50 PM
AndrewLitteken added a reverting change for rG050392660249: [IRSim] Adding support for isomorphic predicates: rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates".
Dec 23 2020, 1:14 PM
AndrewLitteken committed rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates" (authored by AndrewLitteken).
Revert "[IRSim] Adding support for isomorphic predicates"
Dec 23 2020, 1:14 PM
AndrewLitteken added a reverting change for D87310: [IRSim] Adding support for isomorphic predicates: rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates".
Dec 23 2020, 1:14 PM · Restricted Project
AndrewLitteken committed rG050392660249: [IRSim] Adding support for isomorphic predicates (authored by AndrewLitteken).
[IRSim] Adding support for isomorphic predicates
Dec 23 2020, 1:02 PM
AndrewLitteken committed rGcce473e0c564: [IRSim] Adding commutativity matching to structure checking (authored by AndrewLitteken).
[IRSim] Adding commutativity matching to structure checking
Dec 23 2020, 1:02 PM
AndrewLitteken closed D87310: [IRSim] Adding support for isomorphic predicates.
Dec 23 2020, 1:02 PM · Restricted Project
AndrewLitteken closed D87311: [IRSim] Adding commutativity matching to structure checking.
Dec 23 2020, 1:02 PM · Restricted Project
AndrewLitteken committed rGb1191c843804: [IROutliner] Adding support for elevating constants that are not the same in… (authored by AndrewLitteken).
[IROutliner] Adding support for elevating constants that are not the same in…
Dec 23 2020, 11:03 AM
AndrewLitteken closed D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Dec 23 2020, 11:03 AM · Restricted Project

Dec 19 2020

AndrewLitteken committed rG7c6f28a438b5: [IROutliner] Deduplicating functions that only require inputs. (authored by AndrewLitteken).
[IROutliner] Deduplicating functions that only require inputs.
Dec 19 2020, 3:35 PM
AndrewLitteken added a reverting change for rG5cdc4f57e50b: [IROutliner] Deduplicating functions that only require inputs.: rGb8a2b6af374e: Revert "[IROutliner] Deduplicating functions that only require inputs.".
Dec 19 2020, 3:35 PM
AndrewLitteken committed rGb8a2b6af374e: Revert "[IROutliner] Deduplicating functions that only require inputs." (authored by AndrewLitteken).
Revert "[IROutliner] Deduplicating functions that only require inputs."
Dec 19 2020, 3:35 PM
AndrewLitteken closed D86978: [IROutliner] Deduplicating functions that only require inputs..

The URL was not included in commit message for 5cdc4f57e50bbe0d211c109517c17defe78e0b73. Closing manually.

Dec 19 2020, 3:29 PM · Restricted Project
AndrewLitteken committed rG5cdc4f57e50b: [IROutliner] Deduplicating functions that only require inputs. (authored by AndrewLitteken).
[IROutliner] Deduplicating functions that only require inputs.
Dec 19 2020, 3:26 PM
AndrewLitteken committed rGc52bcf3a9b2d: [IRSim][IROutliner] Limit to extracting regions that only require (authored by AndrewLitteken).
[IRSim][IROutliner] Limit to extracting regions that only require
Dec 19 2020, 11:34 AM
AndrewLitteken closed D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Dec 19 2020, 11:34 AM · Restricted Project

Dec 17 2020

AndrewLitteken closed D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..
Dec 17 2020, 7:17 PM · Restricted Project
AndrewLitteken committed rGcea807602a2f: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding InstVisitor to disallow certain operations.
Dec 17 2020, 5:35 PM
AndrewLitteken requested review of D93475: Updating macOS Version logic for macOS 11+ and Darwin 20+.
Dec 17 2020, 10:52 AM · Restricted Project
AndrewLitteken committed rGdae34463e3e0: [IRSim][IROutliner] Adding the extraction basics for the IROutliner. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding the extraction basics for the IROutliner.
Dec 17 2020, 9:28 AM

Dec 2 2020

AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Updating an incorrect typo introduced from the fix-up patch.

Dec 2 2020, 8:51 PM · Restricted Project
AndrewLitteken added a comment to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

@paquette @jroelofs @yroux for reverting fix.

Dec 2 2020, 8:48 PM · Restricted Project
AndrewLitteken added a reviewer for D86974: [IRSim] Adding basic implementation of llvm-sim.: MaskRay.
Dec 2 2020, 8:35 PM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

These are updates to try to fix the build problem of the llvm-sim executable not being found for tests on Windows and some Linux builds. Unfortunately, I do not have the errors anymore. Is there something else that will need added to add llvm-sim as a tool? The changes I've made reflect what I've found has been done for other tools.

Dec 2 2020, 8:34 PM · Restricted Project