Page MenuHomePhabricator

[IRSim][IROutliner] Adding OptRemarks for the IROutliner.
AcceptedPublic

Authored by AndrewLitteken on Sep 8 2020, 10:20 AM.

Details

Reviewers
paquette
jroelofs
Summary

This places OptRemarks at each location where a decision is made to not outline, or to outline a specific section.

Test:

  • llvm/test/Transforms/IROutliner/opt-remarks.ll

Diff Detail

Event Timeline

AndrewLitteken created this revision.Sep 8 2020, 10:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2020, 10:20 AM
AndrewLitteken requested review of this revision.Sep 8 2020, 10:20 AM

Newline addition.

jroelofs added inline comments.
llvm/include/llvm/Transforms/IPO/IROutliner.h
282

Since this doesn't own the referred-to function, why not use an llvm::function_ref here like the others (GTTI, GIRSI)?

llvm/lib/Transforms/IPO/IROutliner.cpp
1517

FWIW, most diagnostics start with lowercase as their first letter.

1573

llvm::interleave might help here to avoid emitting the trailing space.

AndrewLitteken marked 3 inline comments as done.Sep 14 2020, 10:11 AM

Updating for function_refs, llvm::interleave and capitalization.

This revision is now accepted and ready to land.Sep 14 2020, 1:29 PM