We really want to try and avoid spilling P0, which can be difficult since there's only one register, so try to rematerialize any VCTP instructions.
Since I don't think this there's much difference in really trivial and trivial, probably isTriviallyReMaterializable is enough to capture this.
I haven't seen the codegen before this change, so it wasn't immediately clear to me what exactly the clue here is. I.e., is this testing something that isn't tested with the other changed tests? I am guessing the high register pressure?
Rebased after pre-committing the test, of which I've changed the function name too.
Cheers, that's all clear now.
The isTrullyReallyTrivial is a virtual function so I haven't chosen the name for it.
Ah, blimey, I missed that.
This probably wants to check that the VCTP is not predicated.
A full triple would be better. I think the ".main" is important.
Otherwise, how come it is still not tail predicated?
You can remove hidden.