This is an archive of the discontinued LLVM Phabricator instance.

[ms] [llvm-ml] Allow use of locally-defined variables in expressions
ClosedPublic

Authored by epastor on Sep 1 2020, 8:02 AM.

Details

Summary

MASM allows variables defined by equate statements to be used in expressions.

Diff Detail

Event Timeline

epastor created this revision.Sep 1 2020, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2020, 8:02 AM
epastor requested review of this revision.Sep 1 2020, 8:02 AM
epastor updated this revision to Diff 289243.Sep 1 2020, 11:52 AM

Sync to HEAD

thakis accepted this revision.Sep 3 2020, 1:14 PM
thakis added inline comments.
llvm/test/tools/llvm-ml/variable.test
11

add a CHECK-NOT: .byte 0 here to check that it's exactly 3

This revision is now accepted and ready to land.Sep 3 2020, 1:14 PM
epastor updated this revision to Diff 289808.Sep 3 2020, 2:20 PM

Check that the expression is exactly 3, not just >= 3.

epastor updated this revision to Diff 290316.Sep 7 2020, 10:33 AM

Rebase to HEAD

This revision was landed with ongoing or failed builds.Sep 7 2020, 11:00 AM
This revision was automatically updated to reflect the committed changes.