Adds some simple sanity checks that the support functions for the atomic
builtins do the right thing. This doesn't test concurrency and memory model
issues.
(This review supersedes D81348, due to issues with CCing llvm-commits).
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Ping. I think all of the review issues (originally added in D81348) have been addressed so this is probably ready to land.
Comment Actions
Under what circumstances does this test actually get built? By default, the builtins library doesn't provide these functions, so this will fail to link.
Comment Actions
This test is gated on REQUIRES: librt_has_atomic. For the relevant platforms, I would configure Compiler-RT with -DCOMPILER_RT_HAS_ATOMIC_KEYWORD=ON -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=OFF and the test would run and link successfully. IIRC, by default COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN is set to YES, so the test is not run, so there shouldn't be any unexpected linking failures (if you found such a case please let me know).