Page MenuHomePhabricator

Enable OpenMP offloading to VE and enable tests for offloading to VE
Needs ReviewPublic

Authored by kosmynin on Aug 13 2020, 2:06 PM.



OpenMP offloading to VE requires a cross-compiled OpenMP runtime and compiler-rt.

The compiler-rt files need to be placed in the build directory to run the tests, but the OpenMP runtime can be placed elsewhere with the CMake variable LIBOMPTARGET_OPENMP_HOST_RTL_FOLDER pointing to it.
The patch uses this CMake variable to set the library search path and the runtime VE_LD_LIBRARY_PATH environment variable for VE tests.

Diff Detail

Unit TestsFailed

0 mslinux > libomptarget.api::omp_get_num_devices_with_empty_target.c
Script: -- : 'RUN: at line 1'; echo ignored-command

Event Timeline

manorom created this revision.Aug 13 2020, 2:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 13 2020, 2:06 PM
manorom requested review of this revision.Aug 13 2020, 2:06 PM
simoll added a project: Restricted Project.Aug 14 2020, 12:41 AM
protze.joachim added inline comments.

Unrelated to this patch, but why are different separators used for Darwin?


I think, this should only be set for the specific device RUN-lines. I suggest to include the flags and export of the environment variable in the definition of %libomptarget-compile-ve-unknown-linux-unknown.

manorom updated this revision to Diff 287660.Aug 25 2020, 7:15 AM
manorom edited the summary of this revision. (Show Details)
  • Move VE specific vars into test run line
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 5:53 AM
kosmynin commandeered this revision.Mar 22 2022, 5:59 AM
kosmynin added a reviewer: manorom.