Page MenuHomePhabricator

tcramer (Tim Cramer)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2015, 6:43 AM (240 w, 2 d)

Recent Activity

Mar 1 2019

tcramer added a comment to D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.

All concerns should be addressed now.

Mar 1 2019, 10:09 AM · Restricted Project, Restricted Project
tcramer updated the diff for D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Mar 1 2019, 10:07 AM · Restricted Project, Restricted Project

Feb 28 2019

tcramer retitled D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end from [OMPT] Handling of the events of implicit-task-begin and implicit-task-end to [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Feb 28 2019, 4:27 AM · Restricted Project, Restricted Project
tcramer updated the summary of D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Feb 28 2019, 4:20 AM · Restricted Project, Restricted Project
tcramer created D58776: [OMPT] Handling of the events of initial-task-begin and initial-task-end.
Feb 28 2019, 4:16 AM · Restricted Project, Restricted Project

Mar 21 2016

tcramer updated subscribers of D18172: [CUDA][OpenMP] Add a generic offload action builder.
Mar 21 2016, 1:31 AM
tcramer updated subscribers of D18170: [CUDA][OpenMP] Create generic offload toolchains.
Mar 21 2016, 1:31 AM
tcramer updated subscribers of D18171: [CUDA][OpenMP] Create generic offload action.
Mar 21 2016, 1:31 AM

Feb 25 2016

tcramer updated subscribers of D9888: [OPENMP] Driver support for OpenMP offloading.
Feb 25 2016, 12:04 AM

Jan 20 2016

tcramer updated D16347: [OMPT]: Fix the order of implicit_task_end_events.
Jan 20 2016, 1:39 AM
tcramer updated subscribers of D16347: [OMPT]: Fix the order of implicit_task_end_events.
Jan 20 2016, 1:22 AM
tcramer updated subscribers of D16347: [OMPT]: Fix the order of implicit_task_end_events.
Jan 20 2016, 1:20 AM
tcramer retitled D16347: [OMPT]: Fix the order of implicit_task_end_events from to [OMPT]: Fix the order of implicit_task_end_events.
Jan 20 2016, 1:12 AM

Oct 13 2015

tcramer added a comment to D13689: Add OMPT events for API locking.

In reading this patch over again, I realized that you implemented the OMPT TR2 lock initialization callback rather than the OMPT working draft, which also passes a lock hint and a lock type to the init callback. The OMPT implementation in LLVM OpenMP is evolving with the current version of the OMPT draft. There are features already in the code that aren't in OMPT TR2. Fort that reason, I think you should add the lock hint and lock type parameters.

Oct 13 2015, 9:46 AM
tcramer added a comment to D13689: Add OMPT events for API locking.

I notice that there aren't any patches to kmp_gsupport.c. I looked in that file and didn't see any support for locking. What will happen when using gcc with this support? Will the instrumented locking routines be called to generate the promised callbacks?

Yes these functions will be called. The OpenMP lock functions are simply normal C functions which are called by the compiler just like any other extern function. They are not name-mangled in a compiler specific fashion, or generated in any special way, so the correct functions will be called at no extra effort.

Oct 13 2015, 9:23 AM
tcramer updated the diff for D13689: Add OMPT events for API locking.

Changed OMPT_BLAME to OMPT_TRACE for the acquire, init and destroy lock events (thanks John for reading the patch carefully!).

Oct 13 2015, 9:21 AM
tcramer retitled D13689: Add OMPT events for API locking from to Add OMPT events for API locking.
Oct 13 2015, 2:17 AM

Jul 1 2015

tcramer retitled D10863: OMPT event_barrier_end fix from to OMPT event_barrier_end fix.
Jul 1 2015, 12:08 AM

May 7 2015

tcramer closed D9335: Liboffload: Patch for MPSS > 3.4.x.
May 7 2015, 12:45 AM

Apr 29 2015

tcramer retitled D9335: Liboffload: Patch for MPSS > 3.4.x from to Liboffload: Patch for MPSS > 3.4.x.
Apr 29 2015, 1:51 AM