This is an archive of the discontinued LLVM Phabricator instance.

Differential D85675

[XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory
ClosedPublic

Authored by jasonliu on Aug 10 2020, 11:30 AM.

Details

Reviewers
DiggerLin
hubert.reinterpretcast
daltenty
MaskRay
jhenderson
Commits
rG0dc5e0cd393d: [XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory
Summary

COFF and XCOFF in llvm are very different and serves different platform.
Since we have different Dumper.cpp file in llvm-readobj's implementation, we should have separate testing directory for them too.

Diff Detail

Event Timeline

jasonliu created this revision.Aug 10 2020, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2020, 11:30 AM
Herald added subscribers: llvm-commits, rupprecht. · View Herald Transcript
jasonliu requested review of this revision.Aug 10 2020, 11:31 AM
DiggerLin accepted this revision.Aug 10 2020, 12:20 PM

LGTM

This revision is now accepted and ready to land.Aug 10 2020, 12:20 PM
Harbormaster completed remote builds in B67769: Diff 284456.Aug 10 2020, 12:42 PM
jhenderson accepted this revision.Aug 11 2020, 2:05 AM

If you want to take this a step further, remove "xcoff" from all the file name prefixes, since they are now implicitly for XCOFF due to their directory. If there's a functional benefit for that being done in a separate commit then that's fine with me. LGTM in either case.

jasonliu updated this revision to Diff 284708.Aug 11 2020, 7:21 AM

Rename the tests, and remove xcoff prefix.

jhenderson accepted this revision.Aug 11 2020, 7:25 AM

LGTM

Closed by commit rG0dc5e0cd393d: [XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory (authored by jasonliu). · Explain WhyAug 11 2020, 10:32 AM
This revision was automatically updated to reflect the committed changes.
jasonliu added a commit: rG0dc5e0cd393d: [XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory.

Revision Contents

Diff 284456

llvm/test/tools/llvm-readobj/COFF/Inputs/aix_xcoff_xlc_test8.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/aix_xcoff_xlc_test8.o.

llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-64.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-64.o.

llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-neg-sym-count.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-neg-sym-count.o.

llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-neg-time.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-neg-time.o.

llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic.o.

llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-reloc-overflow.o

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-reloc-overflow.o.

llvm/test/tools/llvm-readobj/COFF/reloc_overflow.test

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/reloc_overflow.test.

llvm/test/tools/llvm-readobj/COFF/xcoff-basic.test

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/xcoff-basic.test.

llvm/test/tools/llvm-readobj/COFF/xcoff-overflow-section.test

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/xcoff-overflow-section.test.

llvm/test/tools/llvm-readobj/COFF/xcoff-sections.test

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/xcoff-sections.test.

llvm/test/tools/llvm-readobj/COFF/xcoff-symbols.test

  • This file was moved to llvm/test/tools/llvm-readobj/XCOFF/xcoff-symbols.test.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/aix_xcoff_xlc_test8.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/aix_xcoff_xlc_test8.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-64.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-64.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-neg-sym-count.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-neg-sym-count.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic-neg-time.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic-neg-time.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-basic.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-basic.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/Inputs/xcoff-reloc-overflow.o

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/Inputs/xcoff-reloc-overflow.o.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/reloc_overflow.test

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/reloc_overflow.test.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/xcoff-basic.test

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/xcoff-basic.test.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/xcoff-overflow-section.test

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/xcoff-overflow-section.test.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/xcoff-sections.test

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/xcoff-sections.test.
The contents of this file were not changed.

llvm/test/tools/llvm-readobj/XCOFF/xcoff-symbols.test

  • This file was moved from llvm/test/tools/llvm-readobj/COFF/xcoff-symbols.test.
The contents of this file were not changed.