[XCOFF][llvm-readobj] Move XCOFF test to XCOFF directory

[jasonliu]

Summary

COFF and XCOFF in llvm are very different and serves different platform.
Since we have different Dumper.cpp file in llvm-readobj's implementation, we should have separate testing directory for them too.

[DiggerLin]

LGTM

[jhenderson]

If you want to take this a step further, remove "xcoff" from all the file name prefixes, since they are now implicitly for XCOFF due to their directory. If there's a functional benefit for that being done in a separate commit then that's fine with me. LGTM in either case.

[jasonliu]

Rename the tests, and remove xcoff prefix.

[jhenderson]

LGTM

llvm/test/tools/llvm-readobj/XCOFF/basic.test

-# RUN: llvm-readobj --file-header %p/Inputs/xcoff-basic.o | \
+# RUN: llvm-readobj --file-header %p/Inputs/basic.o | \
 # RUN: FileCheck --check-prefix=FILEHEADER %s
 #
-# RUN: llvm-readobj --file-header %p/Inputs/xcoff-basic-64.o | \
+# RUN: llvm-readobj --file-header %p/Inputs/basic64.o | \
 # RUN: FileCheck --check-prefix=FILEHEADER64 %s
 
-# RUN: llvm-readobj --file-header %p/Inputs/xcoff-basic-neg-time.o | \
+# RUN: llvm-readobj --file-header %p/Inputs/basic-neg-time.o | \
 # RUN: FileCheck --check-prefix=NEGTIME %s
 
-# RUN: llvm-readobj --file-header %p/Inputs/xcoff-basic-neg-sym-count.o | \
+# RUN: llvm-readobj --file-header %p/Inputs/basic-neg-sym-count.o | \
 # RUN: FileCheck --check-prefix=NEGSYMCOUNT %s
 
-# RUN: llvm-readobj --relocs --expand-relocs %p/Inputs/xcoff-basic.o | \
+# RUN: llvm-readobj --relocs --expand-relocs %p/Inputs/basic.o | \
 # RUN: FileCheck --check-prefix=RELOCSEXP %s
 
-# FILEHEADER:     File: {{.*}}xcoff-basic.o
+# FILEHEADER:     File: {{.*}}basic.o
 # FILEHEADER-NEXT: Format: aixcoff-rs6000
 # FILEHEADER-NEXT: Arch: powerpc
 # FILEHEADER-NEXT: AddressSize: 32bit
 # FILEHEADER-NEXT: FileHeader {
 # FILEHEADER-NEXT:   Magic: 0x1DF
 # FILEHEADER-NEXT:   NumberOfSections: 6
 # FILEHEADER-NEXT:   TimeStamp: 2019-03-12T14:04:43Z (0x5C87BC7B)
 # FILEHEADER-NEXT:   SymbolTableOffset: 0x52E
 # FILEHEADER-NEXT:   SymbolTableEntries: 120
 # FILEHEADER-NEXT:   OptionalHeaderSize: 0x1C
 # FILEHEADER-NEXT:   Flags: 0x0
 # FILEHEADER-NEXT: }
 
-# FILEHEADER64:     File: {{.*}}xcoff-basic-64.o
+# FILEHEADER64:     File: {{.*}}basic64.o
 # FILEHEADER64-NEXT:  Format: aix5coff64-rs6000
 # FILEHEADER64-NEXT:  Arch: powerpc64
 # FILEHEADER64-NEXT:  AddressSize: 64bit
 # FILEHEADER64-NEXT:  FileHeader {
 # FILEHEADER64-NEXT:    Magic: 0x1F7
 # FILEHEADER64-NEXT:    NumberOfSections: 5
 # FILEHEADER64-NEXT:    TimeStamp: 2019-03-18T20:03:47Z (0x5C8FF9A3)
 # FILEHEADER64-NEXT:    SymbolTableOffset: 0x54C
 # FILEHEADER64-NEXT:    SymbolTableEntries: 58
 # FILEHEADER64-NEXT:    OptionalHeaderSize: 0x0
 # FILEHEADER64-NEXT:    Flags: 0x0
 # FILEHEADER64-NEXT:  }
 
-# NEGTIME:     File: {{.*}}xcoff-basic-neg-time.o
+# NEGTIME:     File: {{.*}}basic-neg-time.o
 # NEGTIME-NEXT:  Format: aixcoff-rs6000
 # NEGTIME-NEXT:  Arch: powerpc
 # NEGTIME-NEXT:  AddressSize: 32bit
 # NEGTIME-NEXT:  FileHeader {
 # NEGTIME-NEXT:    Magic: 0x1DF
 # NEGTIME-NEXT:    NumberOfSections: 6
 # NEGTIME-NEXT:    TimeStamp: Reserved Value (0xDC87BC7B)
 # NEGTIME-NEXT:    SymbolTableOffset: 0x52E
 # NEGTIME-NEXT:    SymbolTableEntries: 120
 # NEGTIME-NEXT:    OptionalHeaderSize: 0x1C
 # NEGTIME-NEXT:    Flags: 0x0
 # NEGTIME-NEXT:  }
 
-# NEGSYMCOUNT:     File: {{.*}}xcoff-basic-neg-sym-count.o
+# NEGSYMCOUNT:     File: {{.*}}basic-neg-sym-count.o
 # NEGSYMCOUNT-NEXT:  Format: aixcoff-rs6000
 # NEGSYMCOUNT-NEXT:  Arch: powerpc
 # NEGSYMCOUNT-NEXT:  AddressSize: 32bit
 # NEGSYMCOUNT-NEXT:  FileHeader {
 # NEGSYMCOUNT-NEXT:    Magic: 0x1DF
 # NEGSYMCOUNT-NEXT:    NumberOfSections: 5
 # NEGSYMCOUNT-NEXT:    TimeStamp: 2019-03-12T14:04:43Z (0x5C87BC7B)
 # NEGSYMCOUNT-NEXT:    SymbolTableOffset: 0x0

 # int B() { return b; }
 # int J() { return j; }
 # double D() { return d; }
 #
 # xcoff-basic-neg-time.o was manually edited to include a negative time stamp.
 # xcoff-basic-neg-sym-count.o was stripped using the 'strip' utility, and
 # manually edited to have a negative symbol table entry count.
 
-# RELOCSEXP: File: {{.*}}xcoff-basic.o
+# RELOCSEXP: File: {{.*}}basic.o
 # RELOCSEXP-NEXT: Format: aixcoff-rs6000
 # RELOCSEXP-NEXT: Arch: powerpc
 # RELOCSEXP-NEXT: AddressSize: 32bit
 # RELOCSEXP-NEXT: Relocations [
 # RELOCSEXP-NEXT:  Section (index: 1) .text {
 # RELOCSEXP-NEXT:    Relocation {
 # RELOCSEXP-NEXT:      Virtual Address: 0x2
 # RELOCSEXP-NEXT:      Symbol: a (85)

llvm/test/tools/llvm-readobj/XCOFF/overflow-section.test

-# RUN: llvm-readobj --sections %p/Inputs/xcoff-reloc-overflow.o | \
+# RUN: llvm-readobj --sections %p/Inputs/reloc-overflow.o | \
 # RUN: FileCheck --check-prefix=SECOVERFLOW %s
-# SECOVERFLOW:      File: {{.*}}xcoff-reloc-overflow.o
+# SECOVERFLOW:      File: {{.*}}reloc-overflow.o
 # SECOVERFLOW-NEXT: Format: aixcoff-rs6000
 # SECOVERFLOW-NEXT: Arch: powerpc
 # SECOVERFLOW-NEXT: AddressSize: 32bit
 # SECOVERFLOW-NEXT: Sections [
 # SECOVERFLOW-NEXT:   Section {
 # SECOVERFLOW-NEXT:     Index: 1
 # SECOVERFLOW-NEXT:     Name: .text
 # SECOVERFLOW-NEXT:     PhysicalAddress: 0x0

llvm/test/tools/llvm-readobj/XCOFF/reloc_overflow.test

-# RUN: llvm-readobj --sections %p/Inputs/xcoff-reloc-overflow.o | \
+# RUN: llvm-readobj --sections %p/Inputs/reloc-overflow.o | \
 # RUN: FileCheck --check-prefix=SECOVERFLOW %s
 
-# RUN: llvm-readobj --relocs --expand-relocs %p/Inputs/xcoff-reloc-overflow.o | \
+# RUN: llvm-readobj --relocs --expand-relocs %p/Inputs/reloc-overflow.o | \
 # RUN: FileCheck --check-prefix=RELOCOVERFLOW %s
 
-# SECOVERFLOW:      File: {{.*}}xcoff-reloc-overflow.o
+# SECOVERFLOW:      File: {{.*}}reloc-overflow.o
 # SECOVERFLOW-NEXT: Format: aixcoff-rs6000
 # SECOVERFLOW-NEXT: Arch: powerpc
 # SECOVERFLOW-NEXT: AddressSize: 32bit
 # SECOVERFLOW-NEXT: Sections [
 # SECOVERFLOW-NEXT:   Section {
 # SECOVERFLOW-NEXT:     Index: 1
 # SECOVERFLOW-NEXT:     Name: .text
 # SECOVERFLOW-NEXT:     PhysicalAddress: 0x0

llvm/test/tools/llvm-readobj/XCOFF/sections.test

-# RUN: llvm-readobj --section-headers %p/Inputs/xcoff-basic.o | \
+# RUN: llvm-readobj --section-headers %p/Inputs/basic.o | \
 # RUN: FileCheck --check-prefix=SEC32 %s
 
-# RUN: llvm-readobj --section-headers %p/Inputs/xcoff-basic-64.o | \
+# RUN: llvm-readobj --section-headers %p/Inputs/basic64.o | \
 # RUN: FileCheck --check-prefix=SEC64 %s
 
-# SEC32:     File: {{.*}}xcoff-basic.o
+# SEC32:     File: {{.*}}basic.o
 # SEC32-NEXT:  Format: aixcoff-rs6000
 # SEC32-NEXT:  Arch: powerpc
 # SEC32-NEXT:  AddressSize: 32bit
 # SEC32-NEXT:  Sections [
 # SEC32-NEXT:    Section {
 # SEC32-NEXT:      Index: 1
 # SEC32-NEXT:      Name: .text
 # SEC32-NEXT:      PhysicalAddress: 0x0

 # SEC32-NEXT:      LineNumberPointer: 0x0
 # SEC32-NEXT:      NumberOfRelocations: 0
 # SEC32-NEXT:      NumberOfLineNumbers: 0
 # SEC32-NEXT:      Type: STYP_DEBUG (0x2000)
 # SEC32-NEXT:    }
 # SEC32-NEXT:  ]
 
 
-# SEC64:     File: {{.*}}xcoff-basic-64.o
+# SEC64:     File: {{.*}}basic64.o
 # SEC64-NEXT:  Format: aix5coff64-rs6000
 # SEC64-NEXT:  Arch: powerpc64
 # SEC64-NEXT:  AddressSize: 64bit
 # SEC64-NEXT:  Sections [
 # SEC64-NEXT:    Section {
 # SEC64-NEXT:      Index: 1
 # SEC64-NEXT:      Name: .text
 # SEC64-NEXT:      PhysicalAddress: 0x0

llvm/test/tools/llvm-readobj/XCOFF/symbols.test

 # This file tests the ability of llvm-readobj to display the symbol table for a
 # 32-bit XCOFF object file.
-RUN: llvm-readobj --symbols %p/Inputs/aix_xcoff_xlc_test8.o | \
+# The object file used is generated by the following source file
+# and command on AIX:
+#
+# > cat test8.c
+#
+# extern int i;
+# extern int TestforXcoff;
+# extern int fun(int i);
+# static int static_i;
+# char* p="abcd";
+# int fun1(int j) {
+#   static_i++;
+#   j++;
+#   j=j+*p;
+#   return j;
+# }
+#
+# int main() {
+#   i++;
+#   fun(i);
+#   return fun1(i);
+# }
+#
+# > xlc -c test8.c -o symbol.o
+
+RUN: llvm-readobj --symbols %p/Inputs/symbol.o | \
 RUN: FileCheck --check-prefix=SYMBOL32 %s
 
-SYMBOL32: File: {{.*}}aix_xcoff_xlc_test8.o
+SYMBOL32: File: {{.*}}symbol.o
 SYMBOL32-NEXT: Format: aixcoff-rs6000
 SYMBOL32-NEXT: Arch: powerpc
 SYMBOL32-NEXT: AddressSize: 32bit
 SYMBOL32-NEXT: Symbols [
 SYMBOL32-NEXT:   Symbol {
 SYMBOL32-NEXT:     Index: 0
 SYMBOL32-NEXT:     Name: .file
 SYMBOL32-NEXT:     Value (SymbolTableIndex): 0x0

 SYMBOL32-NEXT:       SymbolAlignmentLog2: 0
 SYMBOL32-NEXT:       SymbolType: XTY_ER (0x0)
 SYMBOL32-NEXT:       StorageMappingClass: XMC_PR (0x0)
 SYMBOL32-NEXT:       StabInfoIndex: 0x0
 SYMBOL32-NEXT:       StabSectNum: 0x0
 SYMBOL32-NEXT:     }
 SYMBOL32-NEXT:   }
 SYMBOL32-NEXT: ]
-
-# The object file used is generated by the following source file
-# and command on AIX:
-#
-# > cat test8.c
-#
-# extern int i;
-# extern int TestforXcoff;
-# extern int fun(int i);
-# static int static_i;
-# char* p="abcd";
-# int fun1(int j) {
-#   static_i++;
-#   j++;
-#   j=j+*p;
-#   return j;
-# }
-#
-# int main() {
-#   i++;
-#   fun(i);
-#   return fun1(i);
-# }
-#
-# > xlc -c test8.c -o aix_xcoff_xlc_test8.o