This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj/elf] - Refine the warning about the broken PT_DYNAMIC segment.
ClosedPublic

Authored by grimar on Aug 10 2020, 8:00 AM.

Details

Summary

Splitted out from D85519.

Currently we report "PT_DYNAMIC segment offset + size exceeds the size of the file",
this changes it to
"PT_DYNAMIC segment offset (0x1234) + file size (0x5678) exceeds the size of the file (0x68ab)"

Diff Detail

Event Timeline

grimar created this revision.Aug 10 2020, 8:00 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Aug 10 2020, 8:00 AM
MaskRay accepted this revision.Aug 13 2020, 9:33 PM

"PT_DYNAMIC segment offset (0x1234) + file size (0x5678) exceeds the size of the file (0x9abc)"

The example needs a change. 0x1234+0x5678 < 0x9abc

This revision is now accepted and ready to land.Aug 13 2020, 9:33 PM
grimar edited the summary of this revision. (Show Details)Aug 17 2020, 4:54 AM