Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D85606

Inliner: handle the convergence control operand bundle
AbandonedPublic
Actions

Authored by sameerds on Aug 9 2020, 7:29 AM.

Details

Reviewers
arsenm
foad
nhaehnle
Summary

Also adjust a comment about alloca handling to reflect the reality of
what the code is actually doing.

Change-Id: Idbe1d7efcb15d64b026ec8530b3083bc64f8ba3b

Diff Detail

Event Timeline

nhaehnle created this revision.Aug 9 2020, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2020, 7:29 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
nhaehnle requested review of this revision.Aug 9 2020, 7:29 AM
Herald added a subscriber: wdng. · View Herald TranscriptAug 9 2020, 7:29 AM
nhaehnle added a parent revision: D85605: LoopUnroll: adjust for new `convergent` semantics.Aug 9 2020, 7:29 AM
Harbormaster completed remote builds in B67630: Diff 284201.Aug 9 2020, 7:30 AM
nhaehnle added a child revision: D85607: CfgTraits: add CfgInstructionRef.Aug 9 2020, 7:31 AM
arsenm added inline comments.Aug 9 2020, 8:35 AM
llvm/test/Transforms/Inline/inline-convergent.ll
91

Can you add a test with multiple, consecutive convergent calleees

nhaehnle updated this revision to Diff 285709.Aug 14 2020, 11:36 AM
  • add another test case
nhaehnle marked an inline comment as done.Aug 14 2020, 11:38 AM
nhaehnle added inline comments.
llvm/test/Transforms/Inline/inline-convergent.ll
91

Done

Harbormaster completed remote builds in B68444: Diff 285709.Aug 14 2020, 11:41 AM
arsenm accepted this revision.Sep 16 2020, 1:49 PM

LGTM

This revision is now accepted and ready to land.Sep 16 2020, 1:49 PM
sameerds mentioned this in D85603: IR: Add convergence control operand bundle and intrinsics.Apr 5 2021, 8:18 AM
sameerds mentioned this in D152431: [Inliner] Handle convergence control when inlining a call.Jun 8 2023, 2:40 AM
sameerds mentioned this in rG8dce4c56dd76: [Inliner] Handle convergence control when inlining a call.Aug 16 2023, 9:26 PM
sameerds commandeered this revision.Aug 21 2023, 11:49 PM
sameerds edited reviewers, added: nhaehnle; removed: sameerds.

Superseded by D152431.

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 11:49 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
sameerds abandoned this revision.Aug 21 2023, 11:50 PM
sameerds marked an inline comment as done.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Utils/
33 lines
test/
Transforms/
Inline/
112 lines

Diff 285709

View Options

llvm/lib/Transforms/Utils/InlineFunction.cpp

Loading...
View Options

llvm/test/Transforms/Inline/inline-convergent.ll

Loading...