This is an archive of the discontinued LLVM Phabricator instance.

Inliner: handle the convergence control operand bundle
AbandonedPublic

Authored by sameerds on Aug 9 2020, 7:29 AM.

Details

Summary

Also adjust a comment about alloca handling to reflect the reality of
what the code is actually doing.

Change-Id: Idbe1d7efcb15d64b026ec8530b3083bc64f8ba3b

Diff Detail

Event Timeline

nhaehnle created this revision.Aug 9 2020, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2020, 7:29 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
nhaehnle requested review of this revision.Aug 9 2020, 7:29 AM
arsenm added inline comments.Aug 9 2020, 8:35 AM
llvm/test/Transforms/Inline/inline-convergent.ll
90

Can you add a test with multiple, consecutive convergent calleees

nhaehnle updated this revision to Diff 285709.Aug 14 2020, 11:36 AM
  • add another test case
nhaehnle marked an inline comment as done.Aug 14 2020, 11:38 AM
nhaehnle added inline comments.
llvm/test/Transforms/Inline/inline-convergent.ll
90

Done

arsenm accepted this revision.Sep 16 2020, 1:49 PM

LGTM

This revision is now accepted and ready to land.Sep 16 2020, 1:49 PM
sameerds commandeered this revision.Aug 21 2023, 11:49 PM
sameerds edited reviewers, added: nhaehnle; removed: sameerds.

Superseded by D152431.

Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 11:49 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
sameerds abandoned this revision.Aug 21 2023, 11:50 PM
sameerds marked an inline comment as done.