This is an archive of the discontinued LLVM Phabricator instance.

Differential D85391

[PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int
ClosedPublic

Authored by aeubanks on Aug 5 2020, 8:05 PM.

Details

Reviewers
kbarton
jsji
nemanjai
hfinkel
Group Reviewers
Restricted Project
Commits
rG1bf4629f1112: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int

Diff Detail

Unit TestsFailed

TimeTest
70 mslinux > Polly.Isl/Ast::alias_checks_with_empty_context.ll

Event Timeline

aeubanks created this revision.Aug 5 2020, 8:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2020, 8:05 PM
Herald added subscribers: llvm-commits, hiraditya, nemanjai. · View Herald Transcript
aeubanks requested review of this revision.Aug 5 2020, 8:05 PM
Herald added a subscriber: • wuzish. · View Herald TranscriptAug 5 2020, 8:05 PM
lkail added reviewers: Restricted Project, jsji, nemanjai.Aug 5 2020, 8:07 PM
Harbormaster completed remote builds in B67242: Diff 283474.Aug 5 2020, 8:19 PM
lkail added a reviewer: hfinkel.Aug 5 2020, 11:39 PM
nemanjai accepted this revision.Aug 7 2020, 5:13 AM

Sure, it's PPC specific and the name should reflect that. Thanks. LGTM.

This revision is now accepted and ready to land.Aug 7 2020, 5:13 AM
This revision was landed with ongoing or failed builds.Aug 7 2020, 11:27 AM
Closed by commit rG1bf4629f1112: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG1bf4629f1112: [PPC] Rename bool-ret-to-int -> ppc-bool-ret-to-int.

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
8 lines
test/
CodeGen/
PowerPC/
2 lines

Diff 283474

llvm/lib/Target/PowerPC/PPCBoolRetToInt.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
#include "llvm/CodeGen/TargetPassConfig.h" #include "llvm/CodeGen/TargetPassConfig.h"
#include "llvm/Support/Casting.h" #include "llvm/Support/Casting.h"
#include <cassert> #include <cassert>
using namespace llvm; using namespace llvm;
namespace { namespace {
#define DEBUG_TYPE "bool-ret-to-int" #define DEBUG_TYPE "ppc-bool-ret-to-int"
STATISTIC(NumBoolRetPromotion, STATISTIC(NumBoolRetPromotion,
"Number of times a bool feeding a RetInst was promoted to an int"); "Number of times a bool feeding a RetInst was promoted to an int");
STATISTIC(NumBoolCallPromotion, STATISTIC(NumBoolCallPromotion,
"Number of times a bool feeding a CallInst was promoted to an int"); "Number of times a bool feeding a CallInst was promoted to an int");
STATISTIC(NumBoolToIntPromotion, STATISTIC(NumBoolToIntPromotion,
"Total number of times a bool was promoted to an int"); "Total number of times a bool was promoted to an int");
▲ Show 20 Lines • Show All 204 Lines • ▼ Show 20 Lines
private: private:
const PPCSubtarget *ST; const PPCSubtarget *ST;
}; };
} // end anonymous namespace } // end anonymous namespace
char PPCBoolRetToInt::ID = 0; char PPCBoolRetToInt::ID = 0;
INITIALIZE_PASS(PPCBoolRetToInt, "bool-ret-to-int", INITIALIZE_PASS(PPCBoolRetToInt, "ppc-bool-ret-to-int",
"Convert i1 constants to i32/i64 if they are returned", "Convert i1 constants to i32/i64 if they are returned", false,
false, false) false)
FunctionPass *llvm::createPPCBoolRetToIntPass() { return new PPCBoolRetToInt(); } FunctionPass *llvm::createPPCBoolRetToIntPass() { return new PPCBoolRetToInt(); }

llvm/test/CodeGen/PowerPC/BoolRetToIntTest.ll

; RUN: opt -bool-ret-to-int -S -o - < %s | FileCheck %s ; RUN: opt -ppc-bool-ret-to-int -S -o - < %s | FileCheck %s
target datalayout = "e-m:e-i64:64-n32:64" target datalayout = "e-m:e-i64:64-n32:64"
target triple = "powerpc64le-unknown-linux-gnu" target triple = "powerpc64le-unknown-linux-gnu"
; CHECK-LABEL: notBoolRet ; CHECK-LABEL: notBoolRet
define signext i32 @notBoolRet() { define signext i32 @notBoolRet() {
entry: entry:
; CHECK: ret i32 1 ; CHECK: ret i32 1
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines