This is an archive of the discontinued LLVM Phabricator instance.

Differential D85054

Add symlinks for `libtool` and `install_name_tool`
ClosedPublic

Authored by sameerarora101 on Jul 31 2020, 3:27 PM.

Details

Reviewers
jhenderson
smeenai
alexander-shaposhnikov
Ktwu
rupprecht
Commits
rGcf26a1051767: Add symlinks for `libtool` and `install_name_tool`
Summary

Add symlinks for llvm-libtool-darwin and
llvm-install-name-tool.

Diff Detail

Event Timeline

sameerarora101 created this revision.Jul 31 2020, 3:27 PM
Herald added a reviewer: rupprecht. · View Herald TranscriptJul 31 2020, 3:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
sameerarora101 requested review of this revision.Jul 31 2020, 3:27 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptJul 31 2020, 3:27 PM
Harbormaster completed remote builds in B66622: Diff 282334.Jul 31 2020, 4:04 PM
jhenderson accepted this revision.Aug 3 2020, 1:17 AM

Assuming those names match the cctools names, LGTM.

This revision is now accepted and ready to land.Aug 3 2020, 1:17 AM
sameerarora101 added a comment.Aug 3 2020, 6:23 AM

yup, libtool and install_name_tool are the cctools names.

smeenai accepted this revision.Aug 4 2020, 2:40 PM

LGTM

Closed by commit rGcf26a1051767: Add symlinks for `libtool` and `install_name_tool` (authored by sameerarora101). · Explain WhyAug 7 2020, 1:47 PM
This revision was automatically updated to reflect the committed changes.
sameerarora101 added a commit: rGcf26a1051767: Add symlinks for `libtool` and `install_name_tool`.

Revision Contents

PathSize
llvm/
tools/
llvm-libtool-darwin/
4 lines
llvm-objcopy/
4 lines

Diff 284037

llvm/tools/llvm-libtool-darwin/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
BinaryFormat BinaryFormat
Object Object
Support Support
) )
add_llvm_tool(llvm-libtool-darwin add_llvm_tool(llvm-libtool-darwin
llvm-libtool-darwin.cpp llvm-libtool-darwin.cpp
) )
if(LLVM_INSTALL_CCTOOLS_SYMLINKS)
add_llvm_tool_symlink(libtool llvm-libtool-darwin)
endif()

llvm/tools/llvm-objcopy/CMakeLists.txt

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
add_llvm_tool_symlink(llvm-install-name-tool llvm-objcopy) add_llvm_tool_symlink(llvm-install-name-tool llvm-objcopy)
add_llvm_tool_symlink(llvm-strip llvm-objcopy) add_llvm_tool_symlink(llvm-strip llvm-objcopy)
if(LLVM_INSTALL_BINUTILS_SYMLINKS) if(LLVM_INSTALL_BINUTILS_SYMLINKS)
add_llvm_tool_symlink(objcopy llvm-objcopy) add_llvm_tool_symlink(objcopy llvm-objcopy)
add_llvm_tool_symlink(strip llvm-objcopy) add_llvm_tool_symlink(strip llvm-objcopy)
endif() endif()
if(LLVM_INSTALL_CCTOOLS_SYMLINKS)
add_llvm_tool_symlink(install_name_tool llvm-install-name-tool)
endif()