Page MenuHomePhabricator

[MLIR][Shape] Lower `shape.broadcast` to `scf`
ClosedPublic

Authored by frgossen on Jul 31 2020, 7:16 AM.

Diff Detail

Event Timeline

frgossen created this revision.Jul 31 2020, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2020, 7:16 AM
frgossen requested review of this revision.Jul 31 2020, 7:16 AM
frgossen added inline comments.Jul 31 2020, 7:21 AM
mlir/lib/Conversion/ShapeToSCF/ShapeToSCF.cpp
32

The function is quite long but I did not think it would help clarity to split this up.

71

As soon as I can rebase to a revision that supports memref<?xindex> this will be gone (before this CL lands).

herhut accepted this revision.Jul 31 2020, 7:30 AM

Looks good. memref<index> has landed upstream so please fix before landing.

mlir/lib/Conversion/ShapeToSCF/ShapeToSCF.cpp
36

nit: shapes has a different meaning for me. Maybe write !shape.shape to be explicit?

This revision is now accepted and ready to land.Jul 31 2020, 7:30 AM
This revision was landed with ongoing or failed builds.Aug 3 2020, 1:20 AM
This revision was automatically updated to reflect the committed changes.