Page MenuHomePhabricator
Differential D84952

[DWARFYAML] Add helper function getDWARFEmitterByName(). NFC.
ClosedPublic
Actions

Authored by Higuoxing on Jul 30 2020, 9:23 AM.

Details

Reviewers
jhenderson
grimar
MaskRay
Commits
rG760e4f22027c: [DWARFYAML] Add helper function getDWARFEmitterByName(). NFC.
Summary

In this patch, we add a helper function getDWARFEmitterByName(). This
function returns the proper DWARF section emitting method by the name.

Diff Detail

Event Timeline

Higuoxing created this revision.Jul 30 2020, 9:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2020, 9:23 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Higuoxing requested review of this revision.Jul 30 2020, 9:23 AM
Higuoxing added a child revision: D84921: [DWARFYAML] Make the debug_aranges entry optional..Jul 30 2020, 9:24 AM
Higuoxing added a comment.Jul 30 2020, 9:39 AM
This comment was removed by Higuoxing.
Harbormaster completed remote builds in B66411: Diff 281956.Jul 30 2020, 9:59 AM
Higuoxing planned changes to this revision.Jul 30 2020, 9:04 PM
Higuoxing updated this revision to Diff 282132.Jul 30 2020, 10:46 PM

Update.

Higuoxing retitled this revision from [DWARFYAML] Refactor emitDebugSections(). NFC. to [DWARFYAML] Add helper function getDWARFEmitterByName(). NFC..Jul 30 2020, 10:46 PM
Higuoxing edited the summary of this revision. (Show Details)
Herald added a subscriber: aprantl. · View Herald TranscriptJul 30 2020, 10:46 PM
Higuoxing updated this revision to Diff 282139.Jul 30 2020, 11:16 PM

Pull out the changes of adding emitDebug[GNU]Pub[names/types] functions.

Higuoxing added a parent revision: D85003: [DWARFYAML] Add emitDebug[GNU]Pub[names/types] functions. NFC..Jul 30 2020, 11:16 PM
Harbormaster completed remote builds in B66501: Diff 282132.Jul 30 2020, 11:26 PM
Harbormaster completed remote builds in B66509: Diff 282139.Jul 30 2020, 11:58 PM
jhenderson added inline comments.Jul 31 2020, 1:50 AM
llvm/lib/ObjectYAML/ELFEmitter.cpp
952

I'm not sure this check is really giving us anything. There's a check in the getDWARFEmitterByName that the name is a recognised name (the default case), so I think you can just remove this check here.

953–955
if (Error Err = EmitFunc(*OS, DWARF);
Higuoxing updated this revision to Diff 282176.Jul 31 2020, 3:40 AM
Higuoxing marked an inline comment as done.

Address review comments.

Thanks for reviewing!

jhenderson accepted this revision.Jul 31 2020, 3:42 AM

LGTM.

This revision is now accepted and ready to land.Jul 31 2020, 3:42 AM
Harbormaster completed remote builds in B66530: Diff 282176.Jul 31 2020, 4:40 AM
Closed by commit rG760e4f22027c: [DWARFYAML] Add helper function getDWARFEmitterByName(). NFC. (authored by Higuoxing). · Explain WhyJul 31 2020, 5:11 AM
This revision was automatically updated to reflect the committed changes.
Higuoxing added a commit: rG760e4f22027c: [DWARFYAML] Add helper function getDWARFEmitterByName(). NFC..

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ObjectYAML/
2 lines
lib/
ObjectYAML/
56 lines
34 lines

Diff 282196

View Options

llvm/include/llvm/ObjectYAML/DWARFEmitter.h

Loading...
View Options

llvm/lib/ObjectYAML/DWARFEmitter.cpp

Loading...
View Options

llvm/lib/ObjectYAML/ELFEmitter.cpp

Loading...