Page MenuHomePhabricator

[Attributor] Call site specific AAValueSimplification and AAIsDead.
AcceptedPublic

Authored by kuter on Jul 27 2020, 9:20 PM.

Details

Summary

This patch makes it possible to do call site specific deductions
for AAValueSimplification and AAIsDead.

Diff Detail

Event Timeline

kuter created this revision.Jul 27 2020, 9:20 PM
Herald added a project: Restricted Project. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 27 2020, 9:45 PM
Harbormaster failed remote builds in B65951: Diff 281102!
kuter requested review of this revision.Jul 27 2020, 9:53 PM

Manually requesting review, since the Phabricator wasn't able to built this. From what I can see it was missing the parent revision with the last build.
Pre-merge checks should be ok now.

kuter retitled this revision from Call site specific AAValueSimplification and AAIsDead. to [Attributor] Call site specific AAValueSimplification and AAIsDead..

Can you, maybe as a separate patch, run the update script with the call site deduction enabled *before* this patch and *after* to get the difference on all tests we have?

llvm/lib/Transforms/IPO/Attributor.cpp
597

is this supposed to be static? Please put it with the other "helpers" and add documentation.

llvm/test/Transforms/Attributor/cb_liveness.ll
185 ↗(On Diff #281102)

Why are there no check lines for TUNIT w/o ENABLED, and CGSCC w/ ENABLED?

kuter added a comment.Jul 29 2020, 4:44 AM

Can you, maybe as a separate patch, run the update script with the call site deduction enabled *before* this patch and *after* to get the difference on all tests we have?

I made D84751.

kuter added inline comments.Jul 29 2020, 4:48 AM
llvm/test/Transforms/Attributor/cb_liveness.ll
185 ↗(On Diff #281102)

Interesting. Will look into it.

kuter updated this revision to Diff 338383.Sun, Apr 18, 9:29 AM
  • Rebase
  • Split the test file into two.
  • Remove the unneeded utility function.
kuter updated this revision to Diff 338384.Sun, Apr 18, 9:41 AM

Remove the TUNIT__ENABLED blocks that I accidentally left in the test files.
ENABLED suffixes are no longer needed since the test file is in two parts now.

jdoerfert accepted this revision.Mon, May 3, 7:50 AM

LG, thanks

This revision is now accepted and ready to land.Mon, May 3, 7:50 AM