Page MenuHomePhabricator

Remove HAVE_VCS_VERSION_INC, not needed
ClosedPublic

Authored by hlopko on Jul 27 2020, 1:29 AM.

Details

Summary

This preprocessor define was meant to be used to conditionally include VCSVersion.inc. However, the define was always set, and it was the content of the header that was conditionally generated. Therefore HAVE_VCS_VERSION_INC should be cleaned up.

Diff Detail

Event Timeline

hlopko created this revision.Jul 27 2020, 1:29 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
hlopko edited the summary of this revision. (Show Details)Jul 27 2020, 1:31 AM
hlopko edited the summary of this revision. (Show Details)Jul 27 2020, 1:31 AM
gribozavr2 accepted this revision.Jul 27 2020, 2:19 AM
This revision is now accepted and ready to land.Jul 27 2020, 2:19 AM

Friendly ping, this change will remove HAVE_VCS_VERSION_INC define. If you disagree, please complain :)

MaskRay accepted this revision.Oct 29 2020, 1:08 PM

Thanks! Assuming you don't have a commit bit, I'll commit on your behalf.

This revision was landed with ongoing or failed builds.Oct 29 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.