Page MenuHomePhabricator
Differential D83861

[MLIR][NFC] Fix clang tidy warnings in misc utilities
ClosedPublic
Actions

Authored by bondhugula on Jul 15 2020, 3:48 AM.

Details

Reviewers
ftynse
mehdi_amini
rriddle
nicolasvasilache
Commits
rGec85d7c8f3ad: [MLIR][NFC] Fix clang tidy warnings in misc utilities
Summary

Fix clang tidy warnings in misc utilities - missing const or a star in
declaration.

Diff Detail

Event Timeline

bondhugula created this revision.Jul 15 2020, 3:48 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJul 15 2020, 3:48 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: msifontes, jurahul, Kayjukh and 12 others. · View Herald Transcript
Harbormaster completed remote builds in B64327: Diff 278133.Jul 15 2020, 4:11 AM
rriddle accepted this revision.Jul 15 2020, 10:24 AM
rriddle marked an inline comment as done.
rriddle added inline comments.
mlir/lib/Transforms/LoopFusion.cpp
366

I've been slightly apprehensive in the past about using * for the iterators, because I feel it exposes internal implementation details of the range.

This revision is now accepted and ready to land.Jul 15 2020, 10:24 AM
bondhugula marked an inline comment as done.Jul 15 2020, 11:56 AM
bondhugula added inline comments.
mlir/lib/Transforms/LoopFusion.cpp
366

Okay, I can roll the iterator ones back.

bondhugula updated this revision to Diff 278269.Jul 15 2020, 11:56 AM

Don't use * for the iterators.

Closed by commit rGec85d7c8f3ad: [MLIR][NFC] Fix clang tidy warnings in misc utilities (authored by bondhugula). · Explain WhyJul 15 2020, 12:01 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B64401: Diff 278269!Jul 15 2020, 12:18 PM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Affine/
Transforms/
4 lines
Utils/
2 lines
Transforms/
4 lines
Utils/
2 lines
6 lines

Diff 278271

View Options

mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp

Loading...
View Options

mlir/lib/Dialect/Affine/Utils/Utils.cpp

Loading...
View Options

mlir/lib/Transforms/LoopFusion.cpp

Loading...
View Options

mlir/lib/Transforms/Utils/LoopFusionUtils.cpp

Loading...
View Options

mlir/lib/Transforms/Utils/LoopUtils.cpp

Loading...