Page MenuHomePhabricator

[MLIR][NFC] Fix clang tidy warnings in misc utilities
ClosedPublic

Authored by bondhugula on Jul 15 2020, 3:48 AM.

Details

Summary

Fix clang tidy warnings in misc utilities - missing const or a star in
declaration.

Diff Detail

Event Timeline

bondhugula created this revision.Jul 15 2020, 3:48 AM
rriddle accepted this revision.Jul 15 2020, 10:24 AM
rriddle marked an inline comment as done.
rriddle added inline comments.
mlir/lib/Transforms/LoopFusion.cpp
366

I've been slightly apprehensive in the past about using * for the iterators, because I feel it exposes internal implementation details of the range.

This revision is now accepted and ready to land.Jul 15 2020, 10:24 AM
bondhugula marked an inline comment as done.Jul 15 2020, 11:56 AM
bondhugula added inline comments.
mlir/lib/Transforms/LoopFusion.cpp
366

Okay, I can roll the iterator ones back.

Don't use * for the iterators.

This revision was automatically updated to reflect the committed changes.