Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/tool/ClangdMain.cpp | ||
---|---|---|
456 | not sure whether we need a new category, probably can live in Features? | |
458 | since we hide this in the CLANGD_ENABLE_REMOTE flag, maybe remove the Hidden? | |
462 | maybe ProjectRoot? | |
699 | the new code section here should be guarded under #ifdef CLANGD_ENABLE_REMOTE | |
704 | if remote-index is on, should we turn off the background index? I think this is our plan, right? | |
706 | nit: use elog. | |
708 | instead of exiting clangd, maybe just continue (since this is not a fatal error), and adjust the error message stating that index-file option is ignored. |
mostly good, just a concern about the linking dependence.
clang-tools-extra/clangd/CMakeLists.txt | ||
---|---|---|
143 ↗ | (On Diff #280593) | the dependence here seems to be a layer violation. we add remote-index library when linking the clangDaemon, but clangdRemoteIndex *depends* on clangDaemon I think we should do this when linking the clangd binary (in clangd/tool/CMakeLists.txt). |
clang-tools-extra/clangd/tool/ClangdMain.cpp | ||
462 | nit: project-path -> project-root. |
clang-tools-extra/clangd/Features.inc.in | ||
---|---|---|
2 | I'm guessing this should be @CLANGD_ENABLE_REMOTE@ |
clang-tools-extra/clangd/tool/ClangdMain.cpp | ||
---|---|---|
699 | I think it should be an #if since the macro is always defined (0 or 1). Doing that in 40d11a878044711708fb6738e4b78a4c9ac3de7b |
clang-tools-extra/clangd/Features.inc.in | ||
---|---|---|
2 | Also, you probably either want #cmakedefine or you want to check with #if instead of #ifdef below. As-is, in the disabled case this will write #define CLANGD_ENABLE_REMOTE 0 in the disabled case, which causes the #ifdef to activate. |
I'm guessing this should be @CLANGD_ENABLE_REMOTE@
The gn build was upset: http://45.33.8.238/linux/23942/step_4.txt
Speculatively fixed in 47a0254229ca425aa4e169c2db14e92b8db86784. Please shout if this was wrong.