Page MenuHomePhabricator

AMDGPUPerfHintAnalysis: reduce indirect and large stride weights
Needs RevisionPublic

Authored by foad on Jul 13 2020, 6:12 AM.

Details

Summary

Reduce the default weight for indirect and large stride accesses. Many
graphics shaders are no more than a couple of thousand instructions in
total, so with the old default weight of 1000, even a single indirect or
large stride access would be enough to push them over the 50% threshold.

Diff Detail

Event Timeline

foad created this revision.Jul 13 2020, 6:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 6:12 AM

Offhand 10 times reduction seems huge. Can you update perfhint.ll to show boundary cases, before and after crossing the threshold?

arsenm requested changes to this revision.Nov 28 2022, 1:08 PM

Needs test?

This revision now requires changes to proceed.Nov 28 2022, 1:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 1:08 PM
Herald added a subscriber: kosarev. · View Herald Transcript