This is an archive of the discontinued LLVM Phabricator instance.

[llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX
ClosedPublic

Authored by stevewan on Jul 10 2020, 11:34 AM.

Details

Summary

The test fails on AIX as it allows open() and read() on a directory. This patch adds `# UNSUPPORTED:
system-aix` to the test to prevent it from running on AIX.

Diff Detail

Event Timeline

stevewan created this revision.Jul 10 2020, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2020, 11:34 AM
stevewan added a comment.EditedJul 10 2020, 11:38 AM

FYI @sameerarora101, we on AIX are experiencing the exact same failure as what has been fixed in D82786 for FreeBSD. This patch adds AIX to the unsupported list as well.

LGTM. Please give other reviewers some time to comment; thanks.

This revision is now accepted and ready to land.Jul 10 2020, 11:41 AM
MaskRay accepted this revision.Jul 10 2020, 11:44 AM
MaskRay retitled this revision from [llvm-ar][AIX] Unsupport test on AIX to [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX.
MaskRay edited the summary of this revision. (Show Details)

Thanks!

sameerarora101 accepted this revision.Jul 10 2020, 11:48 AM

@stevewan Thanks for reporting and the fix. Sorry about the breakage!

smeenai accepted this revision.Jul 10 2020, 4:35 PM

Thanks and sorry for the breakage!

This revision was automatically updated to reflect the committed changes.

@stevenwan

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

llvm/utils/git/pre-push.py can validate the message does not include unneeded tags. Please clean up tags for future commits. Thanks.