Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D83535

[IR] Disable select ? C : undef -> C fold in ConstantFoldSelectInstruction unless we know C isn't poison.
ClosedPublic
Actions

Authored by craig.topper on Jul 9 2020, 11:45 PM.

Details

Reviewers
efriedma
lebedev.ri
nlopes
spatel
reames
Commits
rG1cf6f210a2ed: [IR] Disable select ? C : undef -> C fold in ConstantFoldSelectInstruction…
Summary

This matches the recent change to InstSimplify from D83440.

Diff Detail

Event Timeline

craig.topper created this revision.Jul 9 2020, 11:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2020, 11:45 PM
Herald added subscribers: kerbowa, hiraditya, nhaehnle, jvesely. · View Herald Transcript
Harbormaster completed remote builds in B63695: Diff 276923.Jul 10 2020, 12:43 AM
lebedev.ri accepted this revision.Jul 10 2020, 4:45 AM

LG, thank you

This revision is now accepted and ready to land.Jul 10 2020, 4:45 AM
Closed by commit rG1cf6f210a2ed: [IR] Disable select ? C : undef -> C fold in ConstantFoldSelectInstruction… (authored by craig.topper). · Explain WhyJul 10 2020, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
lib/
IR/
24 lines
test/
Transforms/
InferAddressSpaces/
AMDGPU/
2 lines
InstSimplify/
70 lines

Diff 277098

View Options

llvm/lib/IR/ConstantFold.cpp

Loading...
View Options

llvm/test/Transforms/InferAddressSpaces/AMDGPU/select.ll

Loading...
View Options

llvm/test/Transforms/InstSimplify/select.ll

Loading...