Cleanup is welcome. Thanks for doing this.
We would like llvm-project not to diverge from the working development branch. Can you submit these changes here as well? https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev It'll help make sure the branches stay in sync and changes don't get lost.
Thanks in advance.
This quite an unusual request /setup. I am not sure I understand this “working development branch”, but in general I’d expect any downstream fork of LLVM to be maintained by the fork owner.
Holding off on pushing till the dev branch issue is clarified. Please let me know if Mehdi'd understanding is correct. How do you plan to manage API breaking changes in MLIR that may not be in this dev branch?
Hi @jurahul, there's certainly no objection for you to commit this change in llvm-project, especially if the change is required to keep llvm building properly.
The story behind Eric's request is that the majority of the development in flang/.../Optimizer is happening in the fir-dev branch. That branch is being upstreamed to llvm-project as it is reviewed and approved. The request to commit the change to fir-dev is simply to make the rebase easier. It's solely up to you.