This is an archive of the discontinued LLVM Phabricator instance.

Differential D83197

[CodeGen] Fix warning in DAGTypeLegalizer::SplitVecRes_ExtendOp
ClosedPublic

Authored by david-arm on Jul 6 2020, 1:55 AM.

Details

Reviewers
rengolin
sdesmalen
efriedma
c-rhodes
Commits
rG9e66e9c30a19: [CodeGen] Fix wrong use of getVectorNumElements() in DAGTypeLegalizer…
Summary

This fixes up a warning in the following test:

sve-sext-zext.ll

Diff Detail

Event Timeline

david-arm created this revision.Jul 6 2020, 1:55 AM
Herald added a reviewer: rengolin. · View Herald TranscriptJul 6 2020, 1:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
david-arm added a child revision: D83205: [SVE] Add checks for no warnings in CodeGen/AArch64/sve-sext-zext.ll.Jul 6 2020, 2:56 AM
david-arm added reviewers: sdesmalen, efriedma, c-rhodes.Jul 6 2020, 2:59 AM
Harbormaster completed remote builds in B62966: Diff 275607.Jul 6 2020, 3:03 AM
david-arm updated this revision to Diff 275922.Jul 6 2020, 11:54 PM
efriedma accepted this revision.Jul 7 2020, 2:17 PM

LGTM

This revision is now accepted and ready to land.Jul 7 2020, 2:17 PM
Closed by commit rG9e66e9c30a19: [CodeGen] Fix wrong use of getVectorNumElements() in DAGTypeLegalizer… (authored by david-arm). · Explain WhyJul 8 2020, 1:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
3 lines

Diff 276342

llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp

Show First 20 Lines • Show All 1,772 Lines • ▼ Show 20 Linesvoid DAGTypeLegalizer::SplitVecRes_ExtendOp(SDNode *N, SDValue &Lo,
// - the type of a split source is illegal, // - the type of a split source is illegal,
// - the type of an extended (by doubling element size) source is legal, and // - the type of an extended (by doubling element size) source is legal, and
// - the type of that extended source when split is legal. // - the type of that extended source when split is legal.
// //
// This won't necessarily completely legalize the operation, but it will // This won't necessarily completely legalize the operation, but it will
// more effectively move in the right direction and prevent falling down // more effectively move in the right direction and prevent falling down
// to scalarization in many cases due to the input vector being split too // to scalarization in many cases due to the input vector being split too
// far. // far.
unsigned NumElements = SrcVT.getVectorNumElements(); if ((SrcVT.getVectorMinNumElements() & 1) == 0 &&
if ((NumElements & 1) == 0 &&
SrcVT.getSizeInBits() * 2 < DestVT.getSizeInBits()) { SrcVT.getSizeInBits() * 2 < DestVT.getSizeInBits()) {
LLVMContext &Ctx = *DAG.getContext(); LLVMContext &Ctx = *DAG.getContext();
EVT NewSrcVT = SrcVT.widenIntegerVectorElementType(Ctx); EVT NewSrcVT = SrcVT.widenIntegerVectorElementType(Ctx);
EVT SplitSrcVT = SrcVT.getHalfNumVectorElementsVT(Ctx); EVT SplitSrcVT = SrcVT.getHalfNumVectorElementsVT(Ctx);
EVT SplitLoVT, SplitHiVT; EVT SplitLoVT, SplitHiVT;
std::tie(SplitLoVT, SplitHiVT) = DAG.GetSplitDestVTs(NewSrcVT); std::tie(SplitLoVT, SplitHiVT) = DAG.GetSplitDestVTs(NewSrcVT);
if (TLI.isTypeLegal(SrcVT) && !TLI.isTypeLegal(SplitSrcVT) && if (TLI.isTypeLegal(SrcVT) && !TLI.isTypeLegal(SplitSrcVT) &&
▲ Show 20 Lines • Show All 3,462 Lines • Show Last 20 Lines