Fixes up one warning in this test:
sve-sext-zext.ll
Differential D83195
[CodeGen] Fix a warning in DAGTypeLegalizer::PromoteIntRes_EXTRACT_SUBVECTOR david-arm on Jul 6 2020, 1:47 AM. Authored by
Details Fixes up one warning in this test: sve-sext-zext.ll
Diff Detail
Event TimelineComment Actions nit: The title and commit message speaks of fixing warnings (in some test), but I think many people who don't follow our developments closely will not know what those 'warnings' relate to. Perhaps you can phrase the title as [CodeGen] Fix wrong use of getVectorNumElements in PromoteIntRes_EXTRACT_SUBVECTOR. Also I think it's worth explaining in the commit message why you're moving this code, e.g. getVectorNumElements is not safe for scalable vectors and should normally use getVectorElementCount instead. But because at this point in the code only fixed-width vectors are used, the use of getVectorNumElements is valid. LGTM otherwise. |