scf.if currently lacks folding on true / false conditionals.
Such foldings are a bit more involved than can be addressed immediately.
This revision introduces an eager folding for lowering vector.transfer operations in the presence of unrolling.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp | ||
---|---|---|
215 | Nit: I'd give this a different name. if (inBounds) reads like "if the transfer is in bounds", but in fact means "if there exists a dynamic condition for the transfer to be in bounds" and if (!inBounds) will actually give a static guarantee that the transfer is in bounds. |
Should it be *maybeCstV < *maybeCstUb since we are trying to fold less than?