Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c | ||
---|---|---|
5 | Hi @fpetrogalli, in the same way that you asked @kmclaughlin if she could add the ASM-NOT check line in her patch, are you able to do that here? You'd need to add an additional RUN line though to compile to assembly. Don't worry if it's not possible though! |
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_reinterpret-bfloat.c | ||
---|---|---|
5 | It is possible, but my understanding is that we anyway decided to do this work as a separate patch. |
@david-arm, at the end I decided to add the ASM-NOT test, it was easy and came for free.
Also, I have moved the IR tests in the file with all other bitcasts, using a funcion attribute to enable the bf16 feature only for those functions that deal with bfloats.
Can you remove the duplicate tests before submitting? Otherwise LGTM!
llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll | ||
---|---|---|
9 | Aren't these tests all duplicates of ones in llvm/test/CodeGen/AArch64/sve-bitcast.ll? Looks like you can remove this file completely. |
llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll | ||
---|---|---|
9 | (facepalm). yes, I remember thinking "I have to remove them before updating the patch", and then I forgot... I will do it before submitting. Thank you for pointing this out. |
Hi @fpetrogalli, in the same way that you asked @kmclaughlin if she could add the ASM-NOT check line in her patch, are you able to do that here? You'd need to add an additional RUN line though to compile to assembly. Don't worry if it's not possible though!