[Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library

[sidneym]

Summary

There were some functions in builtins that rightfully belong in the clibrary.

[sidneym]

missed fabs.S

[bcain]

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

[bcain]

In D82263#2122860, @bcain wrote:

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

This change LGTM btw. Just odd that the test failures are here. Perhaps they're due to some more general problem.

[sidneym]

Rebase

compiler-rt/lib/builtins/CMakeLists.txt

set(hexagon_SOURCES
   hexagon/dfaddsub.S
   hexagon/dfdiv.S
   hexagon/dffma.S
   hexagon/dfminmax.S
   hexagon/dfmul.S
   hexagon/dfsqrt.S
   hexagon/divdi3.S
   hexagon/divsi3.S
-  hexagon/fabs_opt.S
   hexagon/fastmath2_dlib_asm.S
   hexagon/fastmath2_ldlib_asm.S
   hexagon/fastmath_dlib_asm.S
-  hexagon/fma_opt.S
-  hexagon/fmax_opt.S
-  hexagon/fmin_opt.S
   hexagon/memcpy_forward_vp4cp4n2.S
   hexagon/memcpy_likely_aligned.S
   hexagon/moddi3.S
   hexagon/modsi3.S
   hexagon/sfdiv_opt.S
   hexagon/sfsqrt_opt.S
   hexagon/udivdi3.S
   hexagon/udivmoddi4.S

compiler-rt/lib/builtins/hexagon/dffma.S

#endif
   //
   // After we add, we need to normalize into upper 64 bits, then compute sticky.
 
   .text
   .global __hexagon_fmadf4
         .type __hexagon_fmadf4,@function
   .global __hexagon_fmadf5
         .type __hexagon_fmadf5,@function
-  .global fma
-  .type fma,@function
   Q6_ALIAS(fmadf5)
   .p2align 5
 __hexagon_fmadf4:
 __hexagon_fmadf5:
-fma:
+.Lfma_begin:
   {
     P_TMP = dfclass(A,#2)
     P_TMP = dfclass(B,#2)
     ATMP = #0
     BTMP = #0
   }
   {
     ATMP = insert(A,#MANTBITS,#EXPBITS-3)
.Lfma_abnormal_ab:
   }
   {
     BTMP = asl(BTMP,TMP)
   }
   {
     B = insert(BTMP,#63,#0)
     AH -= asl(TMP,#HI_MANTBITS)
   }
-  jump fma
+  jump .Lfma_begin
 
 .Lfma_ab_tiny:
   ATMP = combine(##0x00100000,#0)
   {
     A = insert(ATMP,#63,#0)
     B = insert(ATMP,#63,#0)
   }
-  jump fma
+  jump .Lfma_begin
 
 .Lab_inf:
   {
     B = lsr(B,#63)
     p0 = dfclass(C,#0x10)
   }
   {
     A ^= asl(B,#63)

compiler-rt/lib/builtins/hexagon/fabs_opt.S

-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fabs
-  {
-    r1 = clrbit(r1, #31)
-    jumpr r31
-  }
-FUNCTION_END fabs
-
-FUNCTION_BEGIN fabsf
-  {
-    r0 = clrbit(r0, #31)
-    jumpr r31
-  }
-FUNCTION_END fabsf
-
-  .globl fabsl
-  .set fabsl, fabs

compiler-rt/lib/builtins/hexagon/fma_opt.S

-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fmaf
-  r2 += sfmpy(r0, r1)
-  {
-    r0 = r2
-    jumpr r31
-  }
-FUNCTION_END fmaf
-
-  .globl fmal
-  .set fmal, fma

compiler-rt/lib/builtins/hexagon/fmax_opt.S

-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fmaxf
-  {
-    r0 = sfmax(r0, r1)
-    jumpr r31
-  }
-FUNCTION_END fmaxf
-
-  .globl fmaxl
-  .set fmaxl, fmax

compiler-rt/lib/builtins/hexagon/fmin_opt.S

-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fminf
-  {
-    r0 = sfmin(r0, r1)
-    jumpr r31
-  }
-FUNCTION_END fminf
-
-  .globl fminl
-  .set fminl, fmin