Page MenuHomePhabricator

[Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library
ClosedPublic

Authored by sidneym on Jun 20 2020, 11:58 AM.

Details

Summary

There were some functions in builtins that rightfully belong in the clibrary.

Diff Detail

Event Timeline

sidneym created this revision.Jun 20 2020, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2020, 11:58 AM
Herald added subscribers: Restricted Project, mgorny, dberris. · View Herald Transcript
sidneym updated this revision to Diff 272279.Jun 20 2020, 5:03 PM

missed fabs.S

bcain added a comment.Jun 30 2020, 7:35 AM

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

bcain accepted this revision.Jun 30 2020, 10:22 AM

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

This change LGTM btw. Just odd that the test failures are here. Perhaps they're due to some more general problem.

This revision is now accepted and ready to land.Jun 30 2020, 10:22 AM
sidneym updated this revision to Diff 274562.Jun 30 2020, 11:57 AM
This revision was automatically updated to reflect the committed changes.