This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Move SIWholeQuadMode after MachineScheduler
AbandonedPublic

Authored by foad on Jun 19 2020, 7:41 AM.

Details

Reviewers
nhaehnle
Summary

This allows the scheduler to do a better job because it doesn't see the
exec mask manipulation instructions insterted by SIWholeQuadMode which
act as scheduling barriers. In particular, it can do a better job of
grouping image instructions with implicit derivatives.

WORK IN PROGRESS: some tests are still failing, generated code may not
be correct.

Diff Detail

Event Timeline

foad created this revision.Jun 19 2020, 7:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 7:41 AM

I guess this obsoletes D22195?

foad added a comment.Jun 19 2020, 8:55 AM

I guess this obsoletes D22195?

I did not know about that and apparently the author had forgotten it too.

This revision is now accepted and ready to land.Jun 23 2020, 4:55 AM
foad abandoned this revision.Jul 22 2020, 1:05 AM
foad added a subscriber: critson.

Abandoning this half-baked patch. @critson might be working on a fully baked patch in the future...

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.gather4.o.dim.ll