This is an archive of the discontinued LLVM Phabricator instance.

[AST][RecoveryExpr] Add error-bit TemplateArgument

Authored by hokein on Jun 18 2020, 8:22 AM.



We are missing the error-bit somehow if the error-bit is propagated through the code path: "error type/expr" -> "template argument" -> "template specialization type", which will lead to crashes.

Diff Detail

Event Timeline

hokein created this revision.Jun 18 2020, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2020, 8:22 AM
hokein updated this revision to Diff 272963.Jun 24 2020, 3:49 AM

per offline discussion: add error-bit to TemplateArgument which provide a more
general fix for missing error-bit in the code path: "error type/expr" -> "teample argument"
-> "template specialization typ".

sammccall accepted this revision.Jun 24 2020, 5:07 AM
This revision is now accepted and ready to land.Jun 24 2020, 5:07 AM
hokein retitled this revision from [AST][RecoveryExpr] Populate the error-bit from template arguments to TemplateSepcializationType. to [AST][RecoveryExpr] Add error-bit TemplateArgument.Jun 24 2020, 7:11 AM
hokein edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.