[MLIR][Shape] Add constant folding to `shape.rank`

[frgossen]

Summary

Add constant folding for the shape.rank operation of the shape dialect.

Depends On D82028

[silvas]

LGTM modulo renaming of op (discussed in the dependent patch)

mlir/lib/Dialect/Shape/IR/Shape.cpp

450

nit: I think llvm::size from STLHelpers.h could make this a bit shorter.

[silvas]

mlir/test/Dialect/Shape/canonicalize.mlir

453

nit: this test doesn't seem to be testing any new functionality that isn't covered by other tests, so it can be omitted.

[rriddle]

mlir/lib/Dialect/Shape/IR/Shape.cpp

450

Alternatively, shape.getNumElements()?

[frgossen]

Rename, address comments

mlir/lib/Dialect/Shape/IR/Shape.cpp

450

Thanks, didn't see that function.

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td

def Shape_RankOp : Shape_Op<"rank", [NoSideEffect]> {
   let description = [{
     Returns the rank of the shape.
   }];
 
   let arguments = (ins Shape_ShapeType:$shape);
   let results = (outs Shape_SizeType:$rank);
 
   let assemblyFormat = "attr-dict $shape";
+
+  let hasFolder = 1;
 }
 
 def Shape_ToExtentTensorOp : Shape_Op<"to_extent_tensor", [NoSideEffect]> {
   let summary = "Creates a dimension tensor from a shape";
   let description = [{
     Converts a shape to a 1D integral tensor of extents. The number of elements
     in the tensor equals the rank of the shape, and the elements equal the
     extents of the shape.

mlir/lib/Dialect/Shape/IR/Shape.cpp

void GetExtentOp::build(OpBuilder &builder, OperationState &result, Value shape,
                         int64_t dim) {
   auto loc = result.location;
   auto dimAttr = builder.getIndexAttr(dim);
   Value dimValue = builder.create<ConstSizeOp>(loc, dimAttr);
   build(builder, result, shape, dimValue);
 }
 
 //===----------------------------------------------------------------------===//
+// RankOp
+//===----------------------------------------------------------------------===//
+
+OpFoldResult RankOp::fold(ArrayRef<Attribute> operands) {
+  auto shape = operands[0].dyn_cast_or_null<DenseIntElementsAttr>();
+  if (!shape)
+    return {};
+  int64_t rank = shape.getNumElements();
+  Builder builder(getContext());
+  return builder.getIndexAttr(rank);
+}
+
+//===----------------------------------------------------------------------===//
 // NumElementsOp
 //===----------------------------------------------------------------------===//
 
 OpFoldResult NumElementsOp::fold(ArrayRef<Attribute> operands) {
 
   // Fold only when argument constant.
   Attribute shape = operands[0];
   if (!shape)

mlir/test/Dialect/Shape/canonicalize.mlir

 func @f(%arg0 : !shape.shape) {
   // CHECK-NEXT: shape.const_witness true
   // CHECK-NEXT: consume.witness
   // CHECK-NEXT: return
   %0 = shape.cstr_broadcastable %arg0, %arg0
   "consume.witness"(%0) : (!shape.witness) -> ()
   return
 }
+
+// -----
+
+// Fold `rank` based on constant shape.
+// CHECK-LABEL: @fold_rank
+func @fold_rank() -> !shape.size {
+  // CHECK-DAG: %[[RESULT:.*]] = shape.const_size 5
+  // CHECK-DAG: return %[[RESULT]] : !shape.size
+  %shape = shape.const_shape [3, 4, 5, 6, 7]
+  %rank = shape.rank %shape
+  return %rank : !shape.size
+}
+
+// -----
+
+// Do not fold `rank` if shape is dynamic.
+// CHECK-LABEL: @dont_fold_rank
+// CHECK-SAME: (%[[SHAPE:.*]]: !shape.shape) -> !shape.size
+func @dont_fold_rank(%shape : !shape.shape) -> !shape.size {
+  // CHECK-DAG: %[[RESULT:.*]] = shape.rank %[[SHAPE]]
+  // CHECK-DAG: return %[[RESULT]] : !shape.size
+  %rank = shape.rank %shape
+  return %rank : !shape.size
+}