This is an archive of the discontinued LLVM Phabricator instance.

Differential D81902

[mlir] Fix case in MLIRGPUtoSPIRVTransforms
ClosedPublic

Authored by GMNGeoffrey on Jun 15 2020, 7:14 PM.

Details

Reviewers
stephenneuendorffer
mravishankar
antiagainst
herhut
Commits
rGcd93906f93e6: [mlir] Fix case in MLIRGPUtoSPIRVTransforms
Summary

This patch changes the casing of MLIRGPUtoSPIRVTransforms
to be consistent with other transforms libraries.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jun 15 2020, 7:14 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptJun 15 2020, 7:14 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: msifontes, jurahul, Kayjukh and 17 others. · View Herald Transcript
Harbormaster completed remote builds in B60411: Diff 270941.Jun 15 2020, 8:55 PM
antiagainst accepted this revision.Jun 16 2020, 4:56 AM

Ah, good catch! Thanks! :)

This revision is now accepted and ready to land.Jun 16 2020, 4:56 AM
GMNGeoffrey added a comment.Jun 16 2020, 8:45 AM

Lei could you land this for me? I don't have commit access

Closed by commit rGcd93906f93e6: [mlir] Fix case in MLIRGPUtoSPIRVTransforms (authored by GMNGeoffrey, committed by antiagainst). · Explain WhyJun 16 2020, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
GPUToSPIRV/
2 lines

Diff 270941

mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt

set(LLVM_TARGET_DEFINITIONS GPUToSPIRV.td) set(LLVM_TARGET_DEFINITIONS GPUToSPIRV.td)
mlir_tablegen(GPUToSPIRV.cpp.inc -gen-rewriters) mlir_tablegen(GPUToSPIRV.cpp.inc -gen-rewriters)
add_public_tablegen_target(MLIRGPUToSPIRVIncGen) add_public_tablegen_target(MLIRGPUToSPIRVIncGen)
add_mlir_conversion_library(MLIRGPUtoSPIRVTransforms add_mlir_conversion_library(MLIRGPUToSPIRVTransforms
ConvertGPUToSPIRV.cpp ConvertGPUToSPIRV.cpp
ConvertGPUToSPIRVPass.cpp ConvertGPUToSPIRVPass.cpp
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
MLIRGPUToSPIRVIncGen MLIRGPUToSPIRVIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
Show All 9 Lines