This is an archive of the discontinued LLVM Phabricator instance.

Differential D81826

[DWARFYAML][debug_abbrev] Make the abbreviation code optional.
ClosedPublic

Authored by Higuoxing on Jun 15 2020, 1:14 AM.

Details

Reviewers
jhenderson
grimar
MaskRay
• espindola
Commits
rGd261a1c0e0e5: [DWARFYAML][debug_abbrev] Make the abbreviation code optional.
Summary

This patch helps make the Code optional in abbreviations table.

Diff Detail

Event Timeline

Higuoxing created this revision.Jun 15 2020, 1:14 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 15 2020, 1:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, hiraditya, emaste. · View Herald Transcript
Higuoxing added a parent revision: D81820: [ObjectYAML][ELF] Add support for emitting the .debug_abbrev section..Jun 15 2020, 1:14 AM
grimar added inline comments.Jun 15 2020, 2:18 AM
llvm/lib/ObjectYAML/DWARFEmitter.cpp
95

Looks unformatted.

It is also more common to write in the following way I think:

(uint64_t)*AbbrevDecl.Code

(i.e. no brackets around the AbbrevDecl.Code)

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml
285

Could you add a one more DW_TAG_subprogram with the same Code and one more DW_TAG_subprogram after it
somewhere here to demostrate the behavior in this case?

Higuoxing planned changes to this revision.Jun 15 2020, 2:18 AM

Seems that build bots are not happy with this change. I'll update it later.

jhenderson added a comment.EditedJun 15 2020, 2:19 AM

The premerge bot is complaining about several failing tests in ObjectYAML. You should probably investigate those.

Edit to add: oh I see you've spotted that already.

llvm/lib/ObjectYAML/DWARFEmitter.cpp
95

Something looks off in this formatting. Did you run clang-format and/or mean (uint64_t)(*AbbrevDecl.Code) perhaps?

Harbormaster failed remote builds in B60267: Diff 270678!Jun 15 2020, 3:14 AM
Higuoxing updated this revision to Diff 271271.Jun 16 2020, 9:20 PM
Higuoxing marked 3 inline comments as done.

Address comments.

Harbormaster failed remote builds in B60583: Diff 271271!Jun 16 2020, 9:51 PM
jhenderson added inline comments.Jun 17 2020, 1:04 AM
llvm/include/llvm/ObjectYAML/DWARFYAML.h
55

I would suggest you keep this as a Hex64 in this patch, and change it to a uint64_t in a separate patch, although I'm not entirely convinced either way whether it should be done at all. Perhaps @grimar has some thoughts?

Higuoxing updated this revision to Diff 271298.Jun 17 2020, 1:38 AM
Higuoxing marked 2 inline comments as done.

Address comment.

llvm/include/llvm/ObjectYAML/DWARFYAML.h
55

Sure, I will leave it as yaml::Hex64 in this patch. I think dumping abbreviation codes in a decimal format has better readability than dumping it in a hexadecimal format. But I'm convincible here :)

Harbormaster failed remote builds in B60597: Diff 271298!Jun 17 2020, 2:08 AM
grimar added inline comments.Jun 17 2020, 2:17 AM
llvm/include/llvm/ObjectYAML/DWARFYAML.h
55

I'd change to uint64_t, but separatelly. I think that abbreviation codes in a decimal format would probably look better, because it is just an index?

jhenderson accepted this revision.Jun 17 2020, 2:32 AM

LGTM.

This revision is now accepted and ready to land.Jun 17 2020, 2:32 AM
Higuoxing updated this revision to Diff 271574.Jun 17 2020, 9:56 PM

Rebase.

Closed by commit rGd261a1c0e0e5: [DWARFYAML][debug_abbrev] Make the abbreviation code optional. (authored by Higuoxing). · Explain WhyJun 17 2020, 10:07 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B60756: Diff 271574!Jun 17 2020, 10:08 PM

Revision Contents

PathSize
llvm/
include/
llvm/
ObjectYAML/
2 lines
lib/
ObjectYAML/
4 lines
2 lines
test/
ObjectYAML/
MachO/
14 lines
14 lines
10 lines
2 lines
tools/
yaml2obj/
ELF/
DWARF/
46 lines

Diff 271298

llvm/include/llvm/ObjectYAML/DWARFYAML.h

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
struct AttributeAbbrev { struct AttributeAbbrev {
llvm::dwarf::Attribute Attribute; llvm::dwarf::Attribute Attribute;
llvm::dwarf::Form Form; llvm::dwarf::Form Form;
llvm::yaml::Hex64 Value; // Some DWARF5 attributes have values llvm::yaml::Hex64 Value; // Some DWARF5 attributes have values
}; };
struct Abbrev { struct Abbrev {
llvm::yaml::Hex32 Code; Optional<yaml::Hex64> Code;
jhendersonUnsubmitted
Done
ReplyInline Actions

I would suggest you keep this as a Hex64 in this patch, and change it to a uint64_t in a separate patch, although I'm not entirely convinced either way whether it should be done at all. Perhaps @grimar has some thoughts?

jhenderson: I would suggest you keep this as a `Hex64` in this patch, and change it to a `uint64_t` in a…
HiguoxingAuthorUnsubmitted
Done
ReplyInline Actions

Sure, I will leave it as yaml::Hex64 in this patch. I think dumping abbreviation codes in a decimal format has better readability than dumping it in a hexadecimal format. But I'm convincible here :)

Higuoxing: Sure, I will leave it as `yaml::Hex64` in this patch. I think dumping abbreviation codes in a…
grimarUnsubmitted
Not Done
ReplyInline Actions

I'd change to uint64_t, but separatelly. I think that abbreviation codes in a decimal format would probably look better, because it is just an index?

grimar: I'd change to `uint64_t`, but separatelly. I think that abbreviation codes in a decimal format…
llvm::dwarf::Tag Tag; llvm::dwarf::Tag Tag;
llvm::dwarf::Constants Children; llvm::dwarf::Constants Children;
std::vector<AttributeAbbrev> Attributes; std::vector<AttributeAbbrev> Attributes;
}; };
struct ARangeDescriptor { struct ARangeDescriptor {
llvm::yaml::Hex64 Address; llvm::yaml::Hex64 Address;
uint64_t Length; uint64_t Length;
▲ Show 20 Lines • Show All 284 Lines • Show Last 20 Lines

llvm/lib/ObjectYAML/DWARFEmitter.cpp

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines for (auto Str : DI.DebugStrings) {
OS.write(Str.data(), Str.size()); OS.write(Str.data(), Str.size());
OS.write('\0'); OS.write('\0');
} }
return Error::success(); return Error::success();
} }
Error DWARFYAML::emitDebugAbbrev(raw_ostream &OS, const DWARFYAML::Data &DI) { Error DWARFYAML::emitDebugAbbrev(raw_ostream &OS, const DWARFYAML::Data &DI) {
uint64_t AbbrevCode = 0;
for (auto AbbrevDecl : DI.AbbrevDecls) { for (auto AbbrevDecl : DI.AbbrevDecls) {
encodeULEB128(AbbrevDecl.Code, OS); AbbrevCode = AbbrevDecl.Code ? (uint64_t)*AbbrevDecl.Code : AbbrevCode + 1;
encodeULEB128(AbbrevCode, OS);
grimarUnsubmitted
Done
ReplyInline Actions

Looks unformatted.

It is also more common to write in the following way I think:

(uint64_t)*AbbrevDecl.Code

(i.e. no brackets around the AbbrevDecl.Code)

grimar: Looks unformatted. It is also more common to write in the following way I think: ```…
jhendersonUnsubmitted
Done
ReplyInline Actions

Something looks off in this formatting. Did you run clang-format and/or mean (uint64_t)(*AbbrevDecl.Code) perhaps?

jhenderson: Something looks off in this formatting. Did you run clang-format and/or mean `(uint64_t)…
encodeULEB128(AbbrevDecl.Tag, OS); encodeULEB128(AbbrevDecl.Tag, OS);
OS.write(AbbrevDecl.Children); OS.write(AbbrevDecl.Children);
for (auto Attr : AbbrevDecl.Attributes) { for (auto Attr : AbbrevDecl.Attributes) {
encodeULEB128(Attr.Attribute, OS); encodeULEB128(Attr.Attribute, OS);
encodeULEB128(Attr.Form, OS); encodeULEB128(Attr.Form, OS);
if (Attr.Form == dwarf::DW_FORM_implicit_const) if (Attr.Form == dwarf::DW_FORM_implicit_const)
encodeSLEB128(Attr.Value, OS); encodeSLEB128(Attr.Value, OS);
} }
▲ Show 20 Lines • Show All 353 Lines • Show Last 20 Lines

llvm/lib/ObjectYAML/DWARFYAML.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesvoid MappingTraits<DWARFYAML::Data>::mapping(IO &IO, DWARFYAML::Data &DWARF) {
IO.mapOptional("debug_gnu_pubtypes", DWARF.GNUPubTypes); IO.mapOptional("debug_gnu_pubtypes", DWARF.GNUPubTypes);
IO.mapOptional("debug_info", DWARF.CompileUnits); IO.mapOptional("debug_info", DWARF.CompileUnits);
IO.mapOptional("debug_line", DWARF.DebugLines); IO.mapOptional("debug_line", DWARF.DebugLines);
IO.setContext(&oldContext); IO.setContext(&oldContext);
} }
void MappingTraits<DWARFYAML::Abbrev>::mapping(IO &IO, void MappingTraits<DWARFYAML::Abbrev>::mapping(IO &IO,
DWARFYAML::Abbrev &Abbrev) { DWARFYAML::Abbrev &Abbrev) {
IO.mapRequired("Code", Abbrev.Code); IO.mapOptional("Code", Abbrev.Code);
IO.mapRequired("Tag", Abbrev.Tag); IO.mapRequired("Tag", Abbrev.Tag);
IO.mapRequired("Children", Abbrev.Children); IO.mapRequired("Children", Abbrev.Children);
IO.mapRequired("Attributes", Abbrev.Attributes); IO.mapRequired("Attributes", Abbrev.Attributes);
} }
void MappingTraits<DWARFYAML::AttributeAbbrev>::mapping( void MappingTraits<DWARFYAML::AttributeAbbrev>::mapping(
IO &IO, DWARFYAML::AttributeAbbrev &AttAbbrev) { IO &IO, DWARFYAML::AttributeAbbrev &AttAbbrev) {
IO.mapRequired("Attribute", AttAbbrev.Attribute); IO.mapRequired("Attribute", AttAbbrev.Attribute);
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines

llvm/test/ObjectYAML/MachO/DWARF-BigEndian.yaml

Show First 20 Lines • Show All 380 Lines • ▼ Show 20 Lines
#CHECK: - int #CHECK: - int
#CHECK: - di_int #CHECK: - di_int
#CHECK: - long long int #CHECK: - long long int
#CHECK: - __absvdi2 #CHECK: - __absvdi2
#CHECK: - a #CHECK: - a
#CHECK: - N #CHECK: - N
#CHECK: - t #CHECK: - t
#CHECK: debug_abbrev: #CHECK: debug_abbrev:
#CHECK: - Code: 0x00000001 #CHECK: - Code: 0x0000000000000001
#CHECK: Tag: DW_TAG_compile_unit #CHECK: Tag: DW_TAG_compile_unit
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_producer #CHECK: - Attribute: DW_AT_producer
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_language #CHECK: - Attribute: DW_AT_language
#CHECK: Form: DW_FORM_data2 #CHECK: Form: DW_FORM_data2
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_stmt_list #CHECK: - Attribute: DW_AT_stmt_list
#CHECK: Form: DW_FORM_sec_offset #CHECK: Form: DW_FORM_sec_offset
#CHECK: - Attribute: DW_AT_comp_dir #CHECK: - Attribute: DW_AT_comp_dir
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Code: 0x00000002 #CHECK: - Code: 0x0000000000000002
#CHECK: Tag: DW_TAG_base_type #CHECK: Tag: DW_TAG_base_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_encoding #CHECK: - Attribute: DW_AT_encoding
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_byte_size #CHECK: - Attribute: DW_AT_byte_size
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Code: 0x00000003 #CHECK: - Code: 0x0000000000000003
#CHECK: Tag: DW_TAG_typedef #CHECK: Tag: DW_TAG_typedef
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Code: 0x00000004 #CHECK: - Code: 0x0000000000000004
#CHECK: Tag: DW_TAG_subprogram #CHECK: Tag: DW_TAG_subprogram
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Attribute: DW_AT_frame_base #CHECK: - Attribute: DW_AT_frame_base
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_prototyped #CHECK: - Attribute: DW_AT_prototyped
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Attribute: DW_AT_external #CHECK: - Attribute: DW_AT_external
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Code: 0x00000005 #CHECK: - Code: 0x0000000000000005
#CHECK: Tag: DW_TAG_formal_parameter #CHECK: Tag: DW_TAG_formal_parameter
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_location #CHECK: - Attribute: DW_AT_location
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Code: 0x00000006 #CHECK: - Code: 0x0000000000000006
#CHECK: Tag: DW_TAG_variable #CHECK: Tag: DW_TAG_variable
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_location #CHECK: - Attribute: DW_AT_location
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Code: 0x00000007 #CHECK: - Code: 0x0000000000000007
#CHECK: Tag: DW_TAG_const_type #CHECK: Tag: DW_TAG_const_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4

llvm/test/ObjectYAML/MachO/DWARF-LittleEndian.yaml

Show First 20 Lines • Show All 369 Lines • ▼ Show 20 Lines
#CHECK: - int #CHECK: - int
#CHECK: - di_int #CHECK: - di_int
#CHECK: - long long int #CHECK: - long long int
#CHECK: - __absvdi2 #CHECK: - __absvdi2
#CHECK: - a #CHECK: - a
#CHECK: - N #CHECK: - N
#CHECK: - t #CHECK: - t
#CHECK: debug_abbrev: #CHECK: debug_abbrev:
#CHECK: - Code: 0x00000001 #CHECK: - Code: 0x0000000000000001
#CHECK: Tag: DW_TAG_compile_unit #CHECK: Tag: DW_TAG_compile_unit
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_producer #CHECK: - Attribute: DW_AT_producer
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_language #CHECK: - Attribute: DW_AT_language
#CHECK: Form: DW_FORM_data2 #CHECK: Form: DW_FORM_data2
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_stmt_list #CHECK: - Attribute: DW_AT_stmt_list
#CHECK: Form: DW_FORM_sec_offset #CHECK: Form: DW_FORM_sec_offset
#CHECK: - Attribute: DW_AT_comp_dir #CHECK: - Attribute: DW_AT_comp_dir
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Code: 0x00000002 #CHECK: - Code: 0x0000000000000002
#CHECK: Tag: DW_TAG_base_type #CHECK: Tag: DW_TAG_base_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_encoding #CHECK: - Attribute: DW_AT_encoding
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_byte_size #CHECK: - Attribute: DW_AT_byte_size
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Code: 0x00000003 #CHECK: - Code: 0x0000000000000003
#CHECK: Tag: DW_TAG_typedef #CHECK: Tag: DW_TAG_typedef
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Code: 0x00000004 #CHECK: - Code: 0x0000000000000004
#CHECK: Tag: DW_TAG_subprogram #CHECK: Tag: DW_TAG_subprogram
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Attribute: DW_AT_frame_base #CHECK: - Attribute: DW_AT_frame_base
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_prototyped #CHECK: - Attribute: DW_AT_prototyped
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Attribute: DW_AT_external #CHECK: - Attribute: DW_AT_external
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Code: 0x00000005 #CHECK: - Code: 0x0000000000000005
#CHECK: Tag: DW_TAG_formal_parameter #CHECK: Tag: DW_TAG_formal_parameter
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_location #CHECK: - Attribute: DW_AT_location
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Code: 0x00000006 #CHECK: - Code: 0x0000000000000006
#CHECK: Tag: DW_TAG_variable #CHECK: Tag: DW_TAG_variable
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_location #CHECK: - Attribute: DW_AT_location
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Code: 0x00000007 #CHECK: - Code: 0x0000000000000007
#CHECK: Tag: DW_TAG_const_type #CHECK: Tag: DW_TAG_const_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: ... #CHECK: ...

llvm/test/ObjectYAML/MachO/DWARF-debug_abbrev.yaml

Show First 20 Lines • Show All 343 Lines • ▼ Show 20 Lines - Code: 0x00000005
Children: DW_CHILDREN_no Children: DW_CHILDREN_no
Attributes: Attributes:
- Attribute: DW_AT_type - Attribute: DW_AT_type
Form: DW_FORM_ref4 Form: DW_FORM_ref4
... ...
#CHECK: DWARF: #CHECK: DWARF:
#CHECK: debug_abbrev: #CHECK: debug_abbrev:
#CHECK: - Code: 0x00000001 #CHECK: - Code: 0x0000000000000001
#CHECK: Tag: DW_TAG_compile_unit #CHECK: Tag: DW_TAG_compile_unit
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_producer #CHECK: - Attribute: DW_AT_producer
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_language #CHECK: - Attribute: DW_AT_language
#CHECK: Form: DW_FORM_data2 #CHECK: Form: DW_FORM_data2
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_stmt_list #CHECK: - Attribute: DW_AT_stmt_list
#CHECK: Form: DW_FORM_sec_offset #CHECK: Form: DW_FORM_sec_offset
#CHECK: - Attribute: DW_AT_comp_dir #CHECK: - Attribute: DW_AT_comp_dir
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Code: 0x00000002 #CHECK: - Code: 0x0000000000000002
#CHECK: Tag: DW_TAG_subprogram #CHECK: Tag: DW_TAG_subprogram
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_low_pc #CHECK: - Attribute: DW_AT_low_pc
#CHECK: Form: DW_FORM_addr #CHECK: Form: DW_FORM_addr
#CHECK: - Attribute: DW_AT_high_pc #CHECK: - Attribute: DW_AT_high_pc
#CHECK: Form: DW_FORM_data4 #CHECK: Form: DW_FORM_data4
#CHECK: - Attribute: DW_AT_frame_base #CHECK: - Attribute: DW_AT_frame_base
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_prototyped #CHECK: - Attribute: DW_AT_prototyped
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Attribute: DW_AT_external #CHECK: - Attribute: DW_AT_external
#CHECK: Form: DW_FORM_flag_present #CHECK: Form: DW_FORM_flag_present
#CHECK: - Code: 0x00000003 #CHECK: - Code: 0x0000000000000003
#CHECK: Tag: DW_TAG_formal_parameter #CHECK: Tag: DW_TAG_formal_parameter
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_location #CHECK: - Attribute: DW_AT_location
#CHECK: Form: DW_FORM_exprloc #CHECK: Form: DW_FORM_exprloc
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_decl_file #CHECK: - Attribute: DW_AT_decl_file
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_decl_line #CHECK: - Attribute: DW_AT_decl_line
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4
#CHECK: - Code: 0x00000004 #CHECK: - Code: 0x0000000000000004
#CHECK: Tag: DW_TAG_base_type #CHECK: Tag: DW_TAG_base_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_name #CHECK: - Attribute: DW_AT_name
#CHECK: Form: DW_FORM_strp #CHECK: Form: DW_FORM_strp
#CHECK: - Attribute: DW_AT_encoding #CHECK: - Attribute: DW_AT_encoding
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Attribute: DW_AT_byte_size #CHECK: - Attribute: DW_AT_byte_size
#CHECK: Form: DW_FORM_data1 #CHECK: Form: DW_FORM_data1
#CHECK: - Code: 0x00000005 #CHECK: - Code: 0x0000000000000005
#CHECK: Tag: DW_TAG_pointer_type #CHECK: Tag: DW_TAG_pointer_type
#CHECK: Children: DW_CHILDREN_no #CHECK: Children: DW_CHILDREN_no
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: DW_AT_type #CHECK: - Attribute: DW_AT_type
#CHECK: Form: DW_FORM_ref4 #CHECK: Form: DW_FORM_ref4

llvm/test/ObjectYAML/MachO/DWARF5-abbrevValues.yaml

Show First 20 Lines • Show All 280 Lines • ▼ Show 20 Lines - Code: 0x00000001
Attributes: Attributes:
- Attribute: 0x2001 - Attribute: 0x2001
Form: DW_FORM_implicit_const Form: DW_FORM_implicit_const
Value: 0x12345678 Value: 0x12345678
... ...
#CHECK: DWARF: #CHECK: DWARF:
#CHECK: debug_abbrev: #CHECK: debug_abbrev:
#CHECK: - Code: 0x00000001 #CHECK: - Code: 0x0000000000000001
#CHECK: Tag: DW_TAG_compile_unit #CHECK: Tag: DW_TAG_compile_unit
#CHECK: Children: DW_CHILDREN_yes #CHECK: Children: DW_CHILDREN_yes
#CHECK: Attributes: #CHECK: Attributes:
#CHECK: - Attribute: 0x2001 #CHECK: - Attribute: 0x2001
#CHECK: Form: DW_FORM_implicit_const #CHECK: Form: DW_FORM_implicit_const
#CHECK: Value: 0x0000000012345678 #CHECK: Value: 0x0000000012345678

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml

Show First 20 Lines • Show All 246 Lines • ▼ Show 20 LinesSections:
- Name: .sec ## Linked by .debug_abbrev. - Name: .sec ## Linked by .debug_abbrev.
Type: SHT_STRTAB Type: SHT_STRTAB
DWARF: DWARF:
debug_abbrev: debug_abbrev:
- Code: 1 - Code: 1
Tag: DW_TAG_compile_unit Tag: DW_TAG_compile_unit
Children: DW_CHILDREN_no Children: DW_CHILDREN_no
Attributes: [] Attributes: []
## h) Test that yaml2obj automatically generates abbreviation codes for us.
# RUN: yaml2obj --docnum=8 %s -o %t8.o
# RUN: llvm-readelf --hex-dump=.debug_abbrev %t8.o | FileCheck %s --check-prefix=CODE
# CODE: 0x00000000 01110000 00022e00 0000042e 00000004
## | | | |
## | | | +- abbreviation code (ULEB128) 0x04
## | | +- abbreviation code (ULEB128) 0x04
## | +- abbreviation code (ULEB128) 0x02
## +- abbreviation code (ULEB128) 0x01
##
# CODE-NEXT: 0x00000010 2e000000 052e0000 00062e00 0000
## | |
## | +- abbreviation code (ULEB128) 0x06
## +- abbreviation code (ULEB128) 0x05
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_EXEC
Machine: EM_X86_64
DWARF:
debug_abbrev:
- Tag: DW_TAG_compile_unit
Children: DW_CHILDREN_no
Attributes: []
- Tag: DW_TAG_subprogram
Children: DW_CHILDREN_no
grimarUnsubmitted
Done
ReplyInline Actions

Could you add a one more DW_TAG_subprogram with the same Code and one more DW_TAG_subprogram after it
somewhere here to demostrate the behavior in this case?

grimar: Could you add a one more `DW_TAG_subprogram` with the same Code and one more…
Attributes: []
- Code: 4
Tag: DW_TAG_subprogram
Children: DW_CHILDREN_no
Attributes: []
- Code: 4
Tag: DW_TAG_subprogram
Children: DW_CHILDREN_no
Attributes: []
- Tag: DW_TAG_subprogram
Children: DW_CHILDREN_no
Attributes: []
- Tag: DW_TAG_subprogram
Children: DW_CHILDREN_no
Attributes: []